Repository navigation
Conversation
Listing 'linearize' in a custom pass list ran it before the symbol definitions, emitting both linearized macros and VLA casts (compile error). Turn it into the homonymous option, as already done for 'openmp'.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3064 +/- ##
==========================================
- Coverage 84.23% 84.23% -0.01%
==========================================
Files 258 258
Lines 57070 57081 +11
Branches 4874 4875 +1
==========================================
+ Hits 48072 48081 +9
- Misses 8170 8172 +2
Partials 828 828
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
opt=('linearize', ...)in a custom pass list ran before symbol definitions, emitting both macros and VLA casts, a compile error. It now becomes the homonymous option, asopenmpalready does.Test:
test_linearize.py::test_linearize_as_pass(three pass-list forms).Both this PR and #3065 append to the bottom of
test_linearize.py; whichever lands second needs a trivial rebase.🤖 Generated with Claude Code