Skip to content

compiler: Run linearize after DataManager when listed as a pass - #3064

Draft
ggorman wants to merge 1 commit into
mainfrom
fix-linearize-as-pass
Draft

ggorman wants to merge 1 commit into
mainfrom
fix-linearize-as-pass

Conversation

@ggorman

@ggorman ggorman commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

opt=('linearize', ...) in a custom pass list ran before symbol definitions, emitting both macros and VLA casts, a compile error. It now becomes the homonymous option, as openmp already does.

Test: test_linearize.py::test_linearize_as_pass (three pass-list forms).

Both this PR and #3065 append to the bottom of test_linearize.py; whichever lands second needs a trivial rebase.

🤖 Generated with Claude Code

Listing 'linearize' in a custom pass list ran it before the symbol
definitions, emitting both linearized macros and VLA casts (compile error).
Turn it into the homonymous option, as already done for 'openmp'.
@codecov

codecov Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.23%. Comparing base (2707ac9) to head (7dba0ec).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3064      +/-   ##
==========================================
- Coverage   84.23%   84.23%   -0.01%     
==========================================
  Files         258      258              
  Lines       57070    57081      +11     
  Branches     4874     4875       +1     
==========================================
+ Hits        48072    48081       +9     
- Misses       8170     8172       +2     
  Partials      828      828              
Flag Coverage Δ
pytest-gpu-aomp-amdgpuX 68.50% <0.00%> (-0.01%) ⬇️
pytest-gpu-gcc- 79.01% <100.00%> (+<0.01%) ⬆️
pytest-gpu-icx- 78.93% <100.00%> (+<0.01%) ⬆️
pytest-gpu-nvc-nvidiaX 69.07% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant