Repository navigation
Conversation
Uxreplace does not recurse into a replacement, so an Indexed nested in the indices of another one (e.g. in a guard `T[0, I[0, 0, 0], 0] < 1.5`) was left in its n-dimensional form while its pointer was flattened, which does not compile. Resolve the nested substitutions innermost first, both when generating FIndexeds and when binding them to macros
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3065 +/- ##
=======================================
Coverage 84.23% 84.23%
=======================================
Files 258 258
Lines 57070 57091 +21
Branches 4874 4877 +3
=======================================
+ Hits 48072 48091 +19
- Misses 8170 8172 +2
Partials 828 828
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uxreplacedoes not recurse into a replacement, soT[0, I[0, 0, 0], 0]in a guard keptIn-dimensional while its pointer was flattened, a compile error. Nested substitutions are now resolved innermost first, both when generating FIndexeds and when binding macros.Test:
test_linearize.py::test_nested_indexeds_in_guard(macro and values); reverting either site fails it.Both this PR and #3064 append to the bottom of
test_linearize.py; whichever lands second needs a trivial rebase.🤖 Generated with Claude Code