Repository navigation
Exclude asynchronous handle scanning from single-threaded builds - #137071
Open
MichalStrehovsky wants to merge 2 commits into
Open
MichalStrehovsky wants to merge 2 commits into
MichalStrehovsky wants to merge 2 commits into
Conversation
Guard asynchronous handle-table dispatch and scanner support with FEATURE_MULTITHREADING. Assert synchronous scan requests without rewriting caller inputs, while preserving handle-table layout and multithreaded behavior. This provides a 2,356 byte size saving for the size-optimized WASI NativeAOT Release Hello World, shrinking it from 825,570 to 823,214 bytes. Validated WASI Release/Checked handle-GC probes and Preinitialization, and built Windows x64 Debug workstation/server GC runtimes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9bc3dfee-1040-4648-bdad-86922a749613
MichalStrehovsky
temporarily deployed
to
copilot-pat-pool
November 6, 2026 10:48 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
|
Azure Pipelines: Successfully started running 3 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
MichalStrehovsky
temporarily deployed
to
copilot-pat-pool
November 6, 2026 10:49 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Contributor
|
Tagging subscribers to this area: @anicka-net, @dotnet/gc |
jkotas
reviewed
Nov 6, 2026
|
|
||
|
|
||
|
|
||
| #ifdef FEATURE_MULTITHREADING |
Member
There was a problem hiding this comment.
Do we need the fine-grained ifdefs - can we let the compiler/linker get rid of the unreachable code?
Keep FEATURE_MULTITHREADING guards only at asynchronous dispatch sites and remove fine-grained scanner and lock-construction guards, addressing review feedback. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b9c54b14-a38c-42b9-89c4-ffacfcc2fe80
jkotas
approved these changes
Nov 7, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard asynchronous handle-table dispatch and scanner support with FEATURE_MULTITHREADING. Assert synchronous scan requests without rewriting caller inputs, while preserving handle-table layout and multithreaded behavior.
Taking the address of the function pulls in 2 kB of unnecessary code. If we don't want to take this PR, it's fine, 2 kB is not a huge deal.