Skip to content

Exclude asynchronous handle scanning from single-threaded builds #137071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MichalStrehovsky wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −0
Open

Exclude asynchronous handle scanning from single-threaded builds #137071

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a67231
Exclude asynchronous handle scanning from single-threaded builds
MichalStrehovsky Nov 6, 2026
88c4fd7
Let the linker discard unreachable asynchronous handle scanners
MichalStrehovsky Nov 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/coreclr/gc/handletable.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,8 +547,12 @@ void HndEnumHandles(HHANDLETABLE hTable, const uint32_t *puType, uint32_t uTypeC

// choose a scanning method based on the async flag
TABLESCANPROC pfnScanTable = TableScanHandles;
#ifdef FEATURE_MULTITHREADING
if (fAsync)
pfnScanTable = xxxTableScanHandlesAsync;
#else // FEATURE_MULTITHREADING
_ASSERTE(!fAsync);
#endif // FEATURE_MULTITHREADING

{
// acquire the handle manager lock
Expand Down Expand Up @@ -663,10 +667,14 @@ void HndScanHandlesForGC(HHANDLETABLE hTable, HANDLESCANPROC scanProc, uintptr_t

// choose a scanning method based on the async flag
TABLESCANPROC pfnScanTable = TableScanHandles;
#ifdef FEATURE_MULTITHREADING
if (flags & HNDGCF_ASYNC)
{
pfnScanTable = xxxTableScanHandlesAsync;
}
#else // FEATURE_MULTITHREADING
_ASSERTE((flags & HNDGCF_ASYNC) == 0);
#endif // FEATURE_MULTITHREADING

{
// lock the table down for concurrent GC only
Expand Down
Loading