Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates Package.swift to use branch dependencies instead of version ranges, specifically targeting the main branch of firebase-ios-sdk and a personal fork of GoogleSignIn-iOS. The feedback highlights that using branch dependencies and personal forks is not suitable for production, as Swift Package Manager prevents packages with branch or revision requirements from being used as dependencies by other packages. It is recommended to revert to official repositories and versioned releases.
| // "8.0.0" ..< "14.0.0" | ||
| branch: "main" |
There was a problem hiding this comment.
Using branch dependencies (such as branch: "main") and leaving commented-out code in Package.swift is not suitable for production. Swift Package Manager does not allow packages that are dependencies of other packages to use branch or revision requirements. Please use a version range requirement instead.
"8.0.0" ..< "14.0.0"| // url: "https://github.com/google/GoogleSignIn-iOS", | ||
| // from: "10.0.0" | ||
| url: "https://github.com/paulb777/GoogleSignIn-iOS", | ||
| branch: "pb-test-swift-app-check" |
There was a problem hiding this comment.
Using a personal fork (paulb777/GoogleSignIn-iOS) and a branch dependency (pb-test-swift-app-check) prevents this package from being resolved correctly when used as a dependency by other packages. Please ensure this is reverted to the official repository with a versioned release before merging.
1 participant
No description provided.