Skip to content

wip: test pre-release Firebase 13 and future compatible GSI #1401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ncooke3 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −3
Open

wip: test pre-release Firebase 13 and future compatible GSI #1401

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,14 @@ let package = Package(
),
.package(
url: "https://github.com/firebase/firebase-ios-sdk.git",
"8.0.0" ..< "13.0.0"
// "8.0.0" ..< "14.0.0"
branch: "main"
Comment on lines +77 to +78

@gemini-code-assist gemini-code-assist Bot Sep 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using branch dependencies (such as branch: "main") and leaving commented-out code in Package.swift is not suitable for production. Swift Package Manager does not allow packages that are dependencies of other packages to use branch or revision requirements. Please use a version range requirement instead.

      "8.0.0" ..< "14.0.0"

),
.package(
url: "https://github.com/google/GoogleSignIn-iOS",
from: "10.0.0"
// url: "https://github.com/google/GoogleSignIn-iOS",
// from: "10.0.0"
url: "https://github.com/paulb777/GoogleSignIn-iOS",
branch: "pb-test-swift-app-check"
Comment on lines +81 to +84

@gemini-code-assist gemini-code-assist Bot Sep 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using a personal fork (paulb777/GoogleSignIn-iOS) and a branch dependency (pb-test-swift-app-check) prevents this package from being resolved correctly when used as a dependency by other packages. Please ensure this is reverted to the official repository with a versioned release before merging.

),
.package(
url: "https://github.com/google/GoogleUtilities.git",
Expand Down
Loading