Repository navigation
fix(security): bump Go to 1.26.10 - #1749
Open
kawacukennedy wants to merge 1 commit into
Open
kawacukennedy wants to merge 1 commit into
kawacukennedy wants to merge 1 commit into
Conversation
govulncheck (the Security workflow) fails on master with a standard-library advisory: Vulnerability floatpane#1: GO-2026-6809 Distrust compromised intermediate certificates in crypto/x509 Found in: crypto/x509@go1.26.9 Fixed in: crypto/x509@go1.26.10 Trace: fetcher.FetchEmailBodyFromMailbox -> pkcs7.PKCS7.VerifyWithChain -> x509.Certificate.Verify Since go.mod pinned go 1.26.9 and the fix shipped in go1.26.10, bump the module's Go directive and the workflow setup-go pins accordingly. govulncheck ./... now reports "No vulnerabilities found".
floatpanebot
added
size/S
floatpanebot
previously requested changes
Oct 21, 2026
floatpanebot
left a comment
floatpanebot
left a comment
Member
There was a problem hiding this comment.
Hi @kawacukennedy! Please fix the following issues with your PR:
- Title: Is too long (48 characters). The PR title must be strictly under 40 characters.
Member
Benchmark report — no significant changeMetrics worse: 0 · better: 0 (threshold: ±3%). benchstat outputauto-generated by benchmarks.yml |
kawacukennedy
changed the title
floatpanebot
dismissed
their stale review
October 21, 2026 06:41
Formatting issues have been resolved. Thank you!
This was referenced Oct 21, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Bump the pinned Go toolchain from
1.26.9to1.26.10:go.mod:go 1.26.9→go 1.26.10setup-gopins that hard-codego-version: "1.26.9"(benchmarks,bot-build,ci,integration,nightly,release-rc,release,security) →1.26.10.Why?
The
Securityworkflow'sgovulncheckjob currently fails onmasterwith a reachable standard-library advisory:GO-2026-6809was published after 1.26.9 and fixed in go1.26.10. Because email body fetching reachesx509.Certificate.Verifyviapkcs7.PKCS7.VerifyWithChain, govulncheck classifies it as your code is affected rather than a module-only finding — so this is a genuine code path, not just a version warning.The
Securityworkflow pins the toolchain viaactions/setup-go'sgo-version, so bumpinggo.modalone is not sufficient; the workflow pins need to move in lockstep. This matches how the previous bump (1.26.7 → 1.26.9) was done.Verification
With Go 1.26.10:
Also ran, all green:
go build ./...,go vet ./...,go test ./..., andgolangci-lint run ./...(0 issues).Fixes #1748