refactor(app): fold engine toggle into the amicode MCP row (#1598) - #1604
Merged
jeonghun-jj-lee merged 1 commit intoSep 28, 2026
Merged
Conversation
Remove the standalone Engine row from the status popover. The 'amicode' entry in the MCP list now doubles as the engine toggle: its dot, switch, and click handler reflect engine lifecycle state (on/booting/off) and send start/stop commands through the extension bridge. - Delete engine-toggle.tsx (standalone component) - Keep engine-toggle-utils.ts (pure parsing + command logic, reused) - Special-case name === 'amicode' in the MCP <For> loop - Show 'Starting…' subtitle during boot, disable switch while locked
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1603 (merged). Removes the standalone Engine row from the status popover and folds the engine start/stop behavior into the existing amicode MCP toggle — the amicode entry IS the engine, so a separate row was redundant.
Changes
engine-toggle.tsx(standalone component)engine-toggle-utils.ts(pure parsing + command logic, reused)name === "amicode"in the MCP<For>loop: dot color, switch state, and click handler reflect engine lifecycle (on/booting/off) instead of MCP connection statusTesting