Repository navigation
Fix bookmark restore landing at wrong position when zoom differs - #1019
Closed
highperformancecoder with Copilot wants to merge 2 commits into
Closed
highperformancecoder with Copilot wants to merge 2 commits into
highperformancecoder with Copilot wants to merge 2 commits into
Conversation
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: highperformancecoder <3075825+highperformancecoder@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix manual bookmarking to save exact location
Fix bookmark restore landing at wrong position when zoom differs
Oct 18, 2026
Owner
|
Decided this was not an issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restoring a manual bookmark doesn't reproduce the saved view. The focus and scale come back different from what was bookmarked, which shows up when navigating nested groups by zooming.
Change in
Group::gotoBookmark_b(model/group.cc)(x, y)at the saved zoom level.moveTo(b.x, b.y)and thenzoom(x(), y(), ...). The zoom scales contents about the group origin, so the saved offset was distorted whenever the current zoom differed from the saved one.Not verified
mmt.mkymodel.Group::zoomonly propagates to child groups whendisplayContents()is true and its state didn't just change. A bookmark that crosses that display threshold may still restore slightly off. That would be a separate cause and isn't addressed here.This change is