Skip to content

Fix bookmark restore landing at wrong position when zoom differs #1019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
+3 −1
Closed

Fix bookmark restore landing at wrong position when zoom differs #1019

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
593adc2
Initial plan
Copilot Oct 18, 2026
8680c3d
Apply remaining changes
Copilot Oct 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion model/group.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1322,8 +1322,10 @@ namespace minsky

void Group::gotoBookmark_b(const Bookmark& b)
{
moveTo(b.x, b.y);
// zoom first (about the group origin), then position, so the
// bookmarked offset is not distorted by the zoom
zoom(x(),y(),b.zoom/(relZoom*zoomFactor()));
moveTo(b.x, b.y);
// TODO add canvas::gotoBookmark to avoid dependency inversion
if (this==cminsky().canvas.model.get()) minsky().canvas.requestRedraw();
}
Expand Down
Loading