Repository navigation
Conversation
The transport is a `hyper.settings.client` edit too, so on a deployment of hyper.video without it, the transport step fails like the other settings steps. Only the microphone, camera and screen share steps apply, and the participant connects with that deployment's default transport.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today, the doc on
apply_all_settingssays that on a hyper.video deployment withouthyper.settings.client, the transport and the microphone and camera state still apply. Since #16, the transport is ahyper.settings.clientedit too, so there its step fails like the other six settings steps. Only the microphone, camera and screen share steps apply, because they click the web app's buttons. The participant connects with the deployment's default transport. A run againstpr-6082.dev.hyper.videoshowed this: sevenFailed to apply …lines, and--transport webrtcconnected over WebTransport.This corrects the doc and changes no code.
Please merge this before tagging
v0.7.0(#18), so that the release carries the corrected doc.