Skip to content

Correct which settings apply without hyper.settings.client #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jlnstrk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Correct which settings apply without hyper.settings.client #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions browser/src/participant/frontend/core.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,10 @@ impl ParticipantInner {

/// Applies the participant's launch settings, each on its own.
///
/// A step that fails is logged, and the steps after it still apply. So on a deployment of hyper.video without
/// `hyper.settings.client`, where every settings edit fails, the transport and the microphone and camera state
/// still apply.
/// A step that fails is logged, and the steps after it still apply. On a deployment of hyper.video without
/// `hyper.settings.client`, every settings edit fails, the transport's included. Only the microphone, camera and
/// screen share steps then apply, because they click the web app's buttons. The participant connects with that
/// deployment's default transport.
async fn apply_all_settings(&self, in_lobby: bool) {
let settings = &self.context.launch_spec.settings;
let driver = self.context.driver.as_ref();
Expand Down
Loading