Repository navigation
Remove the Python divergence entries for the update cases - #44
Merged
Merged
Conversation
idfkit adds IDFObject.update (idfkit/idfkit#235), so the ten python entries for the five update cases, which recorded that idfkit main had no such method, are stale against it. Against the idfkit feature branch at c90639fb, the corpus passes with the seven outstanding python entries for other issues and none stale. The six typescript entries remain until @idfkit/core lands its side. The header is recounted: 18 entries over 7 issues and 12 cases, 7 against python and 11 against typescript.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the ten python entries for the five update cases from
known-divergence.toml. They record that idfkitmainhas noIDFObject.update; the idfkit pull request for idfkit/idfkit#235 adds it, and against that branch every one of them is stale, which fails the run. This follows the precedent of #37: the entries are removed here, the change is released asconformance-2026.18, and the idfkit pull request raises its pin to that tag.The six typescript entries for the update cases remain until
@idfkit/corelands its side (idfkit/idfkit-js#81, stacked on #80).Changes
known-divergence.toml: ten entries removed; the header and the update section's comment recounted from the file: 18 entries over 7 issues and 12 cases, 7 against python and 11 against typescript, on a corpus of 74 cases and 226 assertions.Verification
runners/run.py --libraryagainst the idfkit feature branch atc90639fb: 74 cases, 226 assertions; 216 passed, 7 failed, 3 skipped; the 7 failures are the outstanding python entries for other issues; none stale; exit 0.python -m pytest tests runners/tests -q: 551 passed.tools/validate_governance.py: passes.Effect on idfkit main
At this level idfkit
mainfails the five update cases without an entry. idfkitmainpinsconformance-2026.16and is unaffected until the pull request that addsupdateraises its pin.