fix: reopened sign-in presenter from settings - #19
Merged
Merged
Conversation
- Opened the main scene before requesting its existing authentication sheet. - Preserved account storage and presentation ownership. - Prepared the next patch release and updated identity checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evidence
Settings previously changed shared sheet state without opening the only window that owns the sheet. A disposable native fixture using the production views reproduced the missing presentation after closing that window. Reopening the window before requesting the sheet restored visible presentation.
The background fixture retained prohibited activation policy and unchanged foreground process. It verifies the presentation ordering, not every SwiftUI scene lifecycle. Apple's documented
openWindowaction targets the existing singleton main scene. Independent review found no blockers in this narrow route change.A separate exact
Window/Settingsscene fixture compiled, but prohibited activation prevented its initial scene creation (windows=[]). That attempt is inconclusive, not a passing scene-level regression. No foreground activation or real account operation was used to force the test.Verification