Skip to content

fix: reopened sign-in presenter from settings - #19

Merged
jacobcxdev merged 1 commit into
mainfrom
jacobcxdev/settings-sign-in-window
Sep 23, 2026
Merged

jacobcxdev merged 1 commit into
mainfrom
jacobcxdev/settings-sign-in-window

Conversation

@jacobcxdev

@jacobcxdev jacobcxdev commented Sep 23, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Opened the main window before presenting the existing sign-in sheet from Settings.
  • Preserved the existing authentication flow, sheet ownership and account storage.
  • Prepared version 4.1.4 (52).

Evidence

Settings previously changed shared sheet state without opening the only window that owns the sheet. A disposable native fixture using the production views reproduced the missing presentation after closing that window. Reopening the window before requesting the sheet restored visible presentation.

The background fixture retained prohibited activation policy and unchanged foreground process. It verifies the presentation ordering, not every SwiftUI scene lifecycle. Apple's documented openWindow action targets the existing singleton main scene. Independent review found no blockers in this narrow route change.

A separate exact Window/Settings scene fixture compiled, but prohibited activation prevented its initial scene creation (windows=[]). That attempt is inconclusive, not a passing scene-level regression. No foreground activation or real account operation was used to force the test.

Verification

  • Debug build and full suite passed with release version 4.1.4 (52): 143 tests / 149 runs, zero failures, skips or runtime warnings.
  • Release identity and mutation contracts passed.
  • No real sign-in, sign-out, credential access, global keyboard event or installed-app preference change occurred.

- Opened the main scene before requesting its existing authentication sheet.
- Preserved account storage and presentation ownership.
- Prepared the next patch release and updated identity checks.
@jacobcxdev jacobcxdev self-assigned this Sep 23, 2026
@jacobcxdev
jacobcxdev merged commit a11a8b0 into main Sep 23, 2026
2 checks passed
@jacobcxdev
jacobcxdev deleted the jacobcxdev/settings-sign-in-window branch September 23, 2026 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant