Skip to content

fix: reopened sign-in presenter from settings #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacobcxdev merged 1 commit into from
Sep 23, 2026
Merged

fix: reopened sign-in presenter from settings #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Scripts/check_fork_identity.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ readonly app_id="dev.jacobcx.Xcodes"
readonly tests_id="dev.jacobcx.Xcodes.Tests"
readonly helper_id="dev.jacobcx.Xcodes.Helper"
readonly team_id="K2648T24P4"
readonly marketing_version="4.1.3"
readonly build_number="51"
readonly marketing_version="4.1.4"
readonly build_number="52"
readonly app_copyright="Fork contributions © 2026 JacobCXDev. Upstream contributors retain their copyrights."
# shellcheck disable=SC2016 # Xcode expands this build-setting literal, not the shell.
readonly app_requirement='identifier "dev.jacobcx.Xcodes" and info [CFBundleShortVersionString] >= "1.0.0" and anchor apple generic and certificate leaf[subject.OU] = "$(CODE_SIGNING_SUBJECT_ORGANIZATIONAL_UNIT)"'
Expand Down
12 changes: 6 additions & 6 deletions Xcodes.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1094,7 +1094,7 @@
CODE_SIGN_IDENTITY = "-";
CODE_SIGN_STYLE = Manual;
COMBINE_HIDPI_IMAGES = YES;
CURRENT_PROJECT_VERSION = 51;
CURRENT_PROJECT_VERSION = 52;
DEVELOPMENT_ASSET_PATHS = "\"Xcodes/Preview Content\"";
DEVELOPMENT_TEAM = K2648T24P4;
ENABLE_HARDENED_RUNTIME = NO;
Expand All @@ -1106,7 +1106,7 @@
"@executable_path/../Frameworks",
);
MACOSX_DEPLOYMENT_TARGET = 14.6;
MARKETING_VERSION = 4.1.3;
MARKETING_VERSION = 4.1.4;
PRODUCT_BUNDLE_IDENTIFIER = dev.jacobcx.Xcodes;
PRODUCT_NAME = Xcodes;
PROVISIONING_PROFILE_SPECIFIER = "";
Expand Down Expand Up @@ -1347,7 +1347,7 @@
"CODE_SIGN_IDENTITY[sdk=macosx*]" = "Apple Development";
CODE_SIGN_STYLE = Automatic;
COMBINE_HIDPI_IMAGES = YES;
CURRENT_PROJECT_VERSION = 51;
CURRENT_PROJECT_VERSION = 52;
DEVELOPMENT_ASSET_PATHS = "\"Xcodes/Preview Content\"";
DEVELOPMENT_TEAM = K2648T24P4;
ENABLE_HARDENED_RUNTIME = YES;
Expand All @@ -1359,7 +1359,7 @@
"@executable_path/../Frameworks",
);
MACOSX_DEPLOYMENT_TARGET = 14.6;
MARKETING_VERSION = 4.1.3;
MARKETING_VERSION = 4.1.4;
PRODUCT_BUNDLE_IDENTIFIER = dev.jacobcx.Xcodes;
PRODUCT_NAME = Xcodes;
SWIFT_VERSION = 6.0;
Expand All @@ -1376,7 +1376,7 @@
"CODE_SIGN_IDENTITY[sdk=macosx*]" = "Apple Development";
CODE_SIGN_STYLE = Automatic;
COMBINE_HIDPI_IMAGES = YES;
CURRENT_PROJECT_VERSION = 51;
CURRENT_PROJECT_VERSION = 52;
DEVELOPMENT_ASSET_PATHS = "\"Xcodes/Preview Content\"";
DEVELOPMENT_TEAM = K2648T24P4;
ENABLE_HARDENED_RUNTIME = YES;
Expand All @@ -1388,7 +1388,7 @@
"@executable_path/../Frameworks",
);
MACOSX_DEPLOYMENT_TARGET = 14.6;
MARKETING_VERSION = 4.1.3;
MARKETING_VERSION = 4.1.4;
PRODUCT_BUNDLE_IDENTIFIER = dev.jacobcx.Xcodes;
PRODUCT_NAME = Xcodes;
SWIFT_VERSION = 6.0;
Expand Down
6 changes: 5 additions & 1 deletion Xcodes/Frontend/Preferences/GeneralPreferencePane.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ enum AppleAccountPreferencePresentation: Equatable {

struct GeneralPreferencePane: View {
@EnvironmentObject var appState: AppState
@SwiftUI.Environment(\.openWindow) private var openWindow

var body: some View {
VStack(alignment: .leading) {
Expand All @@ -38,7 +39,10 @@ struct GeneralPreferencePane: View {
case .signedIn:
SignedInView()
case .signedOut:
Button("SignIn", action: { self.appState.presentedSheet = .signIn })
Button("SignIn") {
openWindow(id: "main")
appState.presentedSheet = .signIn
}
}
}
.groupBoxStyle(PreferencesGroupBoxStyle())
Expand Down