Pin SDL3 to the jdolan/SDL ObjectivelyGPU tag - #7
Merged
Merged
Conversation
The SDL_gpu query API that QueryPool uses exists only in the jdolan/SDL fork. SDL3 came from four sources before this change: a 3.4.2 dmg for the xcframework, unpinned Homebrew on macOS CI, and 3.4.12 for Linux CI and Windows. Every one now uses the ObjectivelyGPU tag, which is 3.4.12 plus the query API, so moving that tag changes SDL3 for the whole stack. - fetch-sdl3.sh downloads SDL3.dmg from the tag's release, and downloads again if the tag moves. - sdl3.targets downloads SDL3-devel-VC.zip into libs\SDL3-ObjectivelyGPU. - macOS and Linux CI build SDL3 from the tag. - Releases no longer republish SDL3.xcframework.zip, because the fork publishes it. - The local SDL switch scripts (link-sdl3-local.sh, use-sdl3.sh) and the root copy of fetch-sdl3.sh are removed. A moved tag replaces them. See jdolan/quetoo#1093. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Without SDL_GPU_QUERY_API, QueryPool compiles to a stub and occlusion queries are disabled, with no other sign in the build. A compiler warning makes a build against stock SDL3 visible. See jdolan/quetoo#1093. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The mutable-tag cache can permanently accept an outdated release asset during asynchronous republishing.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Pins SDL3 to the jdolan/SDL ObjectivelyGPU tag across supported platforms.
Changes:
- Updates CI and platform fetchers to use forked SDL3 artifacts.
- Adds missing-query-API warnings and installation guidance.
- Removes obsolete local SDL switching and release packaging.
| File | Description |
|---|---|
Sources/ObjectivelyGPU/QueryPool.c |
Warns when query APIs are unavailable. |
ObjectivelyGPU.xcodeproj/project.pbxproj |
Updates framework script references. |
ObjectivelyGPU.vs15/sdl3.targets |
Fetches tagged Windows libraries. |
Frameworks/use-sdl3.sh |
Removes SDL switching utility. |
Frameworks/link-sdl3-local.sh |
Removes local SDL linker utility. |
Frameworks/fetch-sdl3.sh |
Fetches and caches tagged Apple framework. |
fetch-sdl3.sh |
Removes duplicate root fetcher. |
Documentation/install.md |
Documents the SDL3 pin and update process. |
.github/workflows/release.yml |
Stops republishing SDL3. |
.github/workflows/build.yml |
Builds tagged SDL3 in macOS/Linux CI. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
fetch-sdl3.sh stamped the cache with the tag's commit, even if the publish workflow had not yet rebuilt the release for a moved tag, so the old assets stayed cached for good. It now reads the commit from the release notes and fails if it differs from the tag. It also resolves annotated tags to their commit, and removes the stamp before it replaces the cache. sdl3.targets now removes a partial libs\SDL3-ObjectivelyGPU before the move, which otherwise nested the new directory inside the old one. See jdolan/quetoo#1093. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
gh workflow run only queues the run. Until it finishes, the moved tag's release still serves the previous assets. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins SDL3 for ObjectivelyGPU to the
ObjectivelyGPUtag of jdolan/SDL, which is SDL 3.4.12 plus the SDL_gpu query API thatQueryPoolneeds. See jdolan/quetoo#1093.Before this change SDL3 came from four sources: a 3.4.2 dmg for the xcframework, unpinned Homebrew on macOS CI, and upstream 3.4.12 for Linux CI and Windows. All of them now use the tag, so moving the tag changes SDL3 for the whole stack.
Frameworks/fetch-sdl3.shdownloadsSDL3.dmgfrom the tag's release. It stores the tag's commit SHA and downloads again if the tag moves.sdl3.targetsdownloadsSDL3-devel-VC.zipintolibs\SDL3-ObjectivelyGPU\. TheSDL3-prefix keeps quetoo'sSDL3-*DLL wildcard working.SDL3.xcframework.zip. No consumer reads it, and the fork publishes SDL now.link-sdl3-local.sh,use-sdl3.shand the root copy offetch-sdl3.share removed.QueryPool.cemits a compiler warning if the SDL3 headers lackSDL_GPU_QUERY_API.Documentation/install.mddocuments the tag and how to move it.The fork release is published by
objectivelygpu.ymlon jdolan/SDLmain, from branchobjectivelygpu-3.4.12. That branch also carries D3D12 stubs (the query branch did not compile on D3D12) and three Vulkan fixes. A lavapipe run with validation layers went from 9620VUIDerrors to 0, with the same sample count as Metal.Verified locally:
fetch-sdl3.shdownloads and caches, the xcframework exports the query symbols, the Xcode build of theObjectivelyGPUscheme succeeds without the warning, andQueryPool.cshows the warning against stock Homebrew SDL3.🤖 Generated with Claude Code