Fix 'microxrcedds_agent' name and dependency - #279
Open
David-LP99 wants to merge 2 commits into
Open
Conversation
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
Signed-off-by: David Laseca Perez <davidlaseca@eprosima.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before #237, the micro-ROS-Agent
SuperBuild.cmakeused to refer to the Micro-XRCE-DDS-Agent asxrceagent, which is inconsistent with the name exported by that package (microxrcedds_agent). In #237, the name and dependencies were updated, but not correctly (in line 24 the old name was kept), which caused some issues and was reverted on #239. The current approach works well for Vulcanexus, but can cause problems depending on the workspace configuration or build order.This PR approaches this issue and tries to generate a consistent behaviour for building the package regardless of where the Micro-XRCE-DDS-Agent is coming from.
SuperBuild.cmakeclones/builds itDEPENDS ${_deps}(non-empty) at the end ofSuperBuild.cmakepackage.xmlMain changes
xrceagentare renamed asmicroxrcedds_agentpackage.xmlnow depends onmicroxrcedds_agentas wellmicroxrcedds_agentis not found, it is added as a dependency to the micro-ROS-Agent external project inSuperBuild.cmakemicroxrcedds_agent 3.0.2or higher is needed, since that version starts exporting an EXACT dependency onspdlog 1.9.2, which ensures that the micro-ROS-Agent build doesn't choose a different version from somewhere else