fix: give the React UI a reachable model catalog API URL - #118
Merged
Merged
Conversation
The ui-react ConfigMap never emitted MODEL_CATALOG_API, so every deployment fell back to the image default, http://api.models.mint.local/v2.0.0. Only a local deployment can reach that host. src/lib/tapis-apps.ts sends every Tapis request to that base, and nothing else uses it. So the component location picker added by mintproject/monorepo#255 fails for every user of every non-local deployment. On mint.tacc.utexas.edu the picker appeared to work only from a workstation that resolves mint.local to a development cluster. Derive the key from the model_catalog_api component's own ingress, the same way HASURA_ENDPOINT, DATA_CATALOG_API and ENSEMBLE_MANAGER_API are derived, and add the matching config.model_catalog_api override. Rendered against the mint.tacc.utexas.edu values, the template now emits https://api.models.mint.tacc.utexas.edu/v2.0.0, which answers 200. The chart default is unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M6tnQ7Rs76qJnXJD7jSbtK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ui-reactConfigMap never emittedMODEL_CATALOG_API. Every deployment therefore fell back to the image default,http://api.models.mint.local/v2.0.0. Only a local deployment can reach that host.Effect
src/lib/tapis-apps.tssends every Tapis request to that base, and nothing else uses it. So the component location picker from monorepo#255 fails for every user of every non-local deployment.On
mint.tacc.utexas.eduthe picker looked healthy. That result was false: the workstation that tested it resolvesmint.localto a development cluster. A user without that name would see the picker fail.Change
Derive the key from the
model_catalog_apicomponent ingress, the same way the template already derivesHASURA_ENDPOINT,DATA_CATALOG_APIandENSEMBLE_MANAGER_API. Add the matchingcomponents.ui_react.config.model_catalog_apioverride.Verification
Rendered with the chart defaults, the value does not change:
Rendered with the
mint.tacc.utexas.eduvalues:That host answers 200 for
/v2.0.0/tapis/portals/appsand returns the same application list.🤖 Generated with Claude Code
https://claude.ai/code/session_01M6tnQ7Rs76qJnXJD7jSbtK