Repository navigation
Conversation
The test needs more than 30 destinations from Paris, and a blind today+5 days can land on a day with far fewer free MAX seats. That made the daily Pages deploy fail since 10 October.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: the daily "Deploy to GitHub Pages" run has failed since 10 October, so the live site still serves the 9 October build. Two e2e scenarios ("Back from a route restores the list's scroll") need more than 30 destinations from Paris, and they search today + 5 days. In the current snapshot that day (17 October) has 23.
After: those two scenarios use the snapshot date with the most destinations from Paris, as the round-trip scenario already does for its dates. The suite passes 23/23 locally; without the change the same two fail.
How:
pickBusyDate()inscripts/e2e.mjs, used only by that scenario.