Skip to content

Fix the daily deploy: run the scroll e2e test on a busy date #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davd-gzl wants to merge 1 commit into from
Closed

Fix the daily deploy: run the scroll e2e test on a busy date #96

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion scripts/e2e.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,28 @@ function pickRoundTripDates() {
}
const [RT_DATE, RT_DATE2] = pickRoundTripDates();

// The scroll-restore scenario needs a long "Where to?" list (more than 30 destinations from
// Paris). Some days in the snapshot have far fewer free MAX seats, so pick the snapshot date
// with the most destinations from Paris instead of a blind now+5d.
function pickBusyDate() {
try {
const raw = JSON.parse(readFileSync(join(DIST, "data", "tgvmax.json"), "utf-8"));
const trains = Array.isArray(raw) ? raw : raw.trains || [];
const today = new Date().toISOString().slice(0, 10);
const dests = new Map();
for (const t of trains) {
if (t.origine !== P || t.date < today || t.od_happy_card !== "OUI") continue;
if (!dests.has(t.date)) dests.set(t.date, new Set());
dests.get(t.date).add(t.destination);
}
const [busiest] = [...dests].sort((a, b) => b[1].size - a[1].size || a[0].localeCompare(b[0]))[0] ?? [];
return busiest ?? DATE;
} catch {
return DATE;
}
}
const BUSY_DATE = pickBusyDate();

// --- tiny assertion harness -------------------------------------------------
const results = [];
class Fail extends Error {}
Expand Down Expand Up @@ -685,7 +707,7 @@ await scenario(
for (const [viewport, label] of [[MOBILE, "390px drawer"], [undefined, "1366px column"]]) {
await scenario(
`history: Back from a route restores the list's scroll (${label})`,
`${BASE}?mode=from&from=${enc(P)}&date=${DATE}`,
`${BASE}?mode=from&from=${enc(P)}&date=${BUSY_DATE}`,
async (page) => {
assert(await until(async () => (await $count(page, ".results .group-card")) > 30), "precondition: short list");
const scrollTop = () =>
Expand Down
Loading