Repository navigation
Make Omacom's policy and docs authoritative; fix Intel shim build - #13
Merged
Merged
Conversation
The Aurora import brought in the SiliconForest fork's assistant policy, README and maintenance notes, which describe a personal fork with a siliconforest/next default branch. Replace them with Omacom's: integration/aurora as the integration branch, edge-channel hardware qualification, and the package pin in omarchy-pkgs. The SiliconForest review ledger, source inventory and receipts stay as provenance. Root AGENTS.md is now the single policy; CLAUDE.md, GEMINI.md and .github/copilot-instructions.md link to it. The Copilot link pointed at .github/AGENTS.md, which does not exist. .github/aurora/ is dropped with the workflow that used it. Pass NULL for the new drm_shim_mmap addr argument in the Intel noop shim so it builds again.
[Medium impact] The PR appears safe to merge, with no outstanding findings. SummaryMakes Omacom’s policy and docs authoritative and fixes the Intel shim calls.
Reviews (3) · Last reviewed commit: "Name the source Scott's J613 checks ran ..." · Reviewed by Greptile |
The branch ruleset is not active yet and the package still pins Aurora, so say so. Describe the CI documentation-only exemption and the debugoptimized, assertion-enabled staging build, point full builds at deps.sh, link Scott's J613 report, and separate unsupported admission contracts from qualification that is still pending on edge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #12. Omacom's own policy and docs replace the SiliconForest fork's, and this fixes the Intel shim build. No Asahi driver code changes.
Summary
The policy follows the Mac process: changes land through a reviewed PR with a green
ci / result, imports land as merge commits, and hardware qualification happens on the edge channel before promotion. Admission stays fail-closed.Evidence
drm_shim.h:109declares 7 parameters, whileintel_noop_drm_shim.c:143,164pass 6. Any build that includes the Intel noop shim fails (Greptile P1 on Import Aurora Mesa with M3 Air support and CI #12).readlink .github/copilot-instructions.mdgivesAGENTS.md, which doesn't exist under.github/.After: both calls pass
NULLforaddr, and the Copilot link resolves to the root policy. The Intel fix was checked against the header, not built: CI buildstools=asahi,drm-shimonly. Across the tree there are fourdrm_shim_mmapcall sites: these two, and the two libc wrappers, which already passaddr.ci / resulthere runs both architecture builds.Merge Danger
Door: two-way
Docs, links and a two-argument fix. Revert in one commit.
Blast Radius: policy
Assistant instructions for every tool working in this repo change, as do the README and maintainer docs, plus the Intel noop shim's mmap call. The package, the CI gate and the Asahi drivers are unchanged.
tools/siliconforest/and the SILICONFOREST JSON files the CI reads stay where they are.