Skip to content

Make Omacom's policy and docs authoritative; fix Intel shim build - #13

Merged
maralcbr merged 3 commits into
integration/aurorafrom
omacom-identity
Oct 25, 2026
Merged

maralcbr merged 3 commits into
integration/aurorafrom
omacom-identity

Conversation

@maralcbr

@maralcbr maralcbr commented Oct 25, 2026 •

Copy link
Copy Markdown
Member

Follow-up to #12. Omacom's own policy and docs replace the SiliconForest fork's, and this fixes the Intel shim build. No Asahi driver code changes.

Summary

 AGENTS.md                        # iconidentify's personal-fork policy → Omacom policy (single source)
 CLAUDE.md, GEMINI.md             → AGENTS.md (unchanged links)
-.github/copilot-instructions.md  → AGENTS.md        (resolves to missing .github/AGENTS.md)
+.github/copilot-instructions.md  → ../AGENTS.md
-.github/aurora/                  # policy copy + script for the workflow #12 removed
 README.md, MAINTAINING.md        # siliconforest/next → integration/aurora, edge qualification, omarchy-pkgs pin
 SILICONFOREST-*                  # kept as provenance, linked from README
 src/intel/tools/intel_noop_drm_shim.c
-  drm_shim_mmap(shim_fd, bo->size, ...)        # 6 args; #12 added addr
+  drm_shim_mmap(shim_fd, NULL, bo->size, ...)

The policy follows the Mac process: changes land through a reviewed PR with a green ci / result, imports land as merge commits, and hardware qualification happens on the edge channel before promotion. Admission stays fail-closed.

Evidence

  • Before: drm_shim.h:109 declares 7 parameters, while intel_noop_drm_shim.c:143,164 pass 6. Any build that includes the Intel noop shim fails (Greptile P1 on Import Aurora Mesa with M3 Air support and CI #12). readlink .github/copilot-instructions.md gives AGENTS.md, which doesn't exist under .github/.
    After: both calls pass NULL for addr, and the Copilot link resolves to the root policy. The Intel fix was checked against the header, not built: CI builds tools=asahi,drm-shim only. Across the tree there are four drm_shim_mmap call sites: these two, and the two libc wrappers, which already pass addr. ci / result here runs both architecture builds.

Merge Danger

Door: two-way

Docs, links and a two-argument fix. Revert in one commit.

Blast Radius: policy

Assistant instructions for every tool working in this repo change, as do the README and maintainer docs, plus the Intel noop shim's mmap call. The package, the CI gate and the Asahi drivers are unchanged. tools/siliconforest/ and the SILICONFOREST JSON files the CI reads stay where they are.

The Aurora import brought in the SiliconForest fork's assistant policy, README
and maintenance notes, which describe a personal fork with a siliconforest/next
default branch. Replace them with Omacom's: integration/aurora as the
integration branch, edge-channel hardware qualification, and the package pin in
omarchy-pkgs. The SiliconForest review ledger, source inventory and receipts
stay as provenance.

Root AGENTS.md is now the single policy; CLAUDE.md, GEMINI.md and
.github/copilot-instructions.md link to it. The Copilot link pointed at
.github/AGENTS.md, which does not exist. .github/aurora/ is dropped with the
workflow that used it.

Pass NULL for the new drm_shim_mmap addr argument in the Intel noop shim so it
builds again.
@greptile-apps

greptile-apps Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge, with no outstanding findings.

Summary

Makes Omacom’s policy and docs authoritative and fixes the Intel shim calls.

  • AI tools in the repository follow Omacom’s root policy.
  • Om​​acom’s maintainer docs point contributors to the integration branch and edge release path.
  • Both Intel shim mapping paths pass an address argument.

Reviews (3) · Last reviewed commit: "Name the source Scott's J613 checks ran ..." · Reviewed by Greptile

Comment thread README.md Outdated
Comment thread README.md Outdated
The branch ruleset is not active yet and the package still pins Aurora, so say
so. Describe the CI documentation-only exemption and the debugoptimized,
assertion-enabled staging build, point full builds at deps.sh, link Scott's
J613 report, and separate unsupported admission contracts from qualification
that is still pending on edge.
Scott tested 97a65d8, whose driver code is what #12 merged, so the M3 Air
row is not citing results from an older address layout.
@maralcbr
maralcbr merged commit 147a62f into integration/aurora Oct 25, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant