Skip to content

i18n(ja): restore literal Grafana panel names in performance-tuning-methods.md - #23786

Open
yahonda wants to merge 13 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-performance-tuning-methods-headings-english
Open

i18n(ja): restore literal Grafana panel names in performance-tuning-methods.md#23786
yahonda wants to merge 13 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-performance-tuning-methods-headings-english

Conversation

@yahonda

@yahonda yahonda commented Sep 9, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

performance-tuning-methods.md is a narrative companion doc to grafana-performance-overview-dashboard.md -- it names the same literal Grafana Performance Overview dashboard panels inline. 7 level-4 section headings and several body-text panel-name mentions had been translated into Japanese prose instead of kept as literal English, verified against both upstream/release-8.5 and docs-cn (which keeps these exact multi-panel headings/labels as literal English even while translating the file's other, generic section headings normally).

Also fixed several unrelated defects found in the same close read-through: dropped particles, a couple of MT-artifact scrambles, a missing 3rd item in an enumerated list, and one word-order scramble.

Only 1 inbound anchor reference exists corpus-wide (alert-rules.md, 2 sites) -- its link text is the generic "Performance Analysis and Tuning" doc title, not the specific heading text, and anchors themselves are unchanged, so no other file needs updating.

Which TiDB version(s) do your changes apply to? (Required)

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Standardized terminology and section headings in the Japanese TiDB performance-tuning documentation.
    • Improved Japanese grammar and formatting for clearer readability.
    • Reformatted an example list for easier scanning.
    • No functional or logical content changes.

@ti-chi-bot

ti-chi-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2026
@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: f50d6d81-1693-44b5-ac7d-3d149b7e239b

📥 Commits

Reviewing files that changed from the base of the PR and between 91dc9e0 and 7137fde.

📒 Files selected for processing (1)
  • performance-tuning-methods.md

Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The PR updates Japanese TiDB performance-tuning documentation. It standardizes English panel names, technical terminology, headings, grammar, and example formatting. It does not change functional or logical content.

Changes

Performance tuning documentation

Layer / File(s) Summary
Dashboard names and workload examples
performance-tuning-methods.md
Dashboard panel names and terminology are standardized across SQL, workload, KV, CPU, memory, and TPC-C examples.
Duration and latency terminology
performance-tuning-methods.md
Duration and latency headings, panel references, and descriptions use standardized English names and Japanese terminology.
Storage and raftstore documentation
performance-tuning-methods.md
Storage and raftstore sections update comparison labels, request terminology, grammar, and import instructions.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 7137f

This updates Japanese performance-tuning guidance to use the dashboard’s English panel names and improves wording and formatting. No current merge-readiness risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description explains the changes, affected documentation version, reference links, AI involvement, and applicable change categories. It provides sufficient context for review.
Title check ✅ Passed The title clearly identifies the Japanese localization file and the main change: restoring literal Grafana panel names.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added the missing-translation-status This PR does not have translation status info. label Sep 9, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign csuzhangxc for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 9, 2026
@yahonda
yahonda force-pushed the fix-performance-tuning-methods-headings-english branch from d17d610 to c1a1444 Compare September 9, 2026 01:57
@ti-chi-bot ti-chi-bot Bot added area/develop This PR relates to the area of TiDB App development. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 9, 2026
@yahonda
yahonda force-pushed the fix-performance-tuning-methods-headings-english branch from c1a1444 to 899b03b Compare September 9, 2026 02:01
@ti-chi-bot ti-chi-bot Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 9, 2026
@yahonda
yahonda marked this pull request as ready for review September 9, 2026 06:23
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 70d01666-575e-470e-90f7-92ddb1e7f22e

📥 Commits

Reviewing files that changed from the base of the PR and between a2da298 and ea6f1ed.

📒 Files selected for processing (1)
  • performance-tuning-methods.md

Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review.

Comment thread performance-tuning-methods.md Outdated
Comment thread performance-tuning-methods.md Outdated
Comment thread performance-tuning-methods.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/develop This PR relates to the area of TiDB App development. missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant