i18n(ja): fix phase-name word order to match corpus convention - #23788
i18n(ja): fix phase-name word order to match corpus convention#23788yahonda wants to merge 14 commits into
Conversation
|
Warning Review limit reachedNext included review available in 35 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe changes revise Japanese wording in the DM requirements note and update terminology, metric descriptions, and conclusions in the performance-tuning guide. No public declarations or functional code changed. ChangesDocumentation updates
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: 🔵 Low · up to The Japanese performance guide improves terminology but still contains a dashboard-dimension mismatch and an incorrect CPU comparison baseline. These can mislead users interpreting TiDB performance results, so the documentation corrections should be applied before merge. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
…type descriptions
…arse/compile/execute duration sentence
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Advanced
Run ID: cb649123-c759-496b-8204-210583e3d0d6
📒 Files selected for processing (2)
dm/dm-hardware-and-software-requirements.mdperformance-tuning-practices.md
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review.
What is changed, added or deleted? (Required)
Fixes a word-order defect: EN's "in the
Xphase" construction (name-first, e.g. "theexecutephase takes most of the time") was rendered reversed as label-first フェーズX(e.g. "フェーズexecuteがほとんどの時間を費やします"), instead of the dominant/correctXフェーズ form used across the rest of the corpus. Also fixes several dropped particles, word-order scrambles, and mistranslated literal identifiers (CPU flame-graph function names, Grafana panel names) found while sweeping the same two files for the same defect class.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
Summary by CodeRabbit