Skip to content

i18n(ja): fix phase-name word order to match corpus convention - #23788

Open
yahonda wants to merge 14 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-phase-word-order
Open

i18n(ja): fix phase-name word order to match corpus convention#23788
yahonda wants to merge 14 commits into
pingcap:i18n-ja-release-8.5from
yahonda:fix-phase-word-order

Conversation

@yahonda

@yahonda yahonda commented Sep 9, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Fixes a word-order defect: EN's "in the X phase" construction (name-first, e.g. "the execute phase takes most of the time") was rendered reversed as label-first フェーズX (e.g. "フェーズexecuteがほとんどの時間を費やします"), instead of the dominant/correct Xフェーズ form used across the rest of the corpus. Also fixes several dropped particles, word-order scrambles, and mistranslated literal identifiers (CPU flame-graph function names, Grafana panel names) found while sweeping the same two files for the same defect class.

Which TiDB version(s) do your changes apply to? (Required)

  • i18n-ja-release-8.5 (TiDB Japanese documentation for TiDB 8.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Clarified Japanese terminology and wording in the development and test environment requirements.
    • Updated the Japanese performance-tuning guide with clearer OLTP metrics, SQL behavior descriptions, plan-cache details, and comparison conclusions.

@coderabbitai

coderabbitai Bot commented Sep 9, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Warning

Review limit reached

Next included review available in 35 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 18795aa1-4707-4a93-a203-cdf15e8b54c7

📥 Commits

Reviewing files that changed from the base of the PR and between 7d592db and 7e69265.

📒 Files selected for processing (1)
  • performance-tuning-practices.md
📝 Walkthrough

Walkthrough

The changes revise Japanese wording in the DM requirements note and update terminology, metric descriptions, and conclusions in the performance-tuning guide. No public declarations or functional code changed.

Changes

Documentation updates

Layer / File(s) Summary
DM phase wording
dm/dm-hardware-and-software-requirements.md
Rewords the DM-worker disk-space note to use dumpフェーズ and loadフェーズ.
Performance scenario descriptions
performance-tuning-practices.md
Updates CPU, SQL, execution-phase, plan-cache, latency, CPS, RC Read, and caching descriptions across the documented scenarios and final comparison.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: 🔵 Low · up to 7d592

The Japanese performance guide improves terminology but still contains a dashboard-dimension mismatch and an incorrect CPU comparison baseline. These can mislead users interpreting TiDB performance results, so the documentation corrections should be applied before merge.

Suggested reviewers: qiancai

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the primary change: correcting Japanese phase-name word order. It is concise and directly related to the changes.
Description check ✅ Passed The description explains the translation fixes, identifies the affected TiDB version, provides a related reference, records AI involvement, and completes the applicable change-category checklist.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added the missing-translation-status This PR does not have translation status info. label Sep 9, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign breezewish for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 9, 2026
@yahonda
yahonda marked this pull request as draft September 9, 2026 02:41
@ti-chi-bot ti-chi-bot Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2026
@ti-chi-bot ti-chi-bot Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 9, 2026
@ti-chi-bot ti-chi-bot Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 9, 2026
@yahonda
yahonda marked this pull request as ready for review September 9, 2026 05:38
@ti-chi-bot ti-chi-bot Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 9, 2026

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: cb649123-c759-496b-8204-210583e3d0d6

📥 Commits

Reviewing files that changed from the base of the PR and between a2da298 and 7d592db.

📒 Files selected for processing (2)
  • dm/dm-hardware-and-software-requirements.md
  • performance-tuning-practices.md

Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review.

Comment thread performance-tuning-practices.md Outdated
Comment thread performance-tuning-practices.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant