Repository navigation
Follow-up to #28: README speaker clause and patch 0003 subject - #30
Draft
plotarmordev wants to merge 8 commits into
Draft
plotarmordev wants to merge 8 commits into
plotarmordev wants to merge 8 commits into
Conversation
Restore the "answers as upstream does without flags" rule for the full-model patches and state the per-request temperature, top_p, top_k and seed fields from this PR (0013/0014, CUDA 0002, Metal 0004/0005) as the request-level exception: they need no launch flag, and requests without them are unchanged.
…saurus/Drama-tensorfold into fix/pr28-followups
Credits @krunkosaurus (#28). Lists speaker tags 1-15 (0015, CUDA 0003, Metal 0006) as a flag-free request feature in the README, and gives CUDA patch 0003 the series' 'server:' subject prefix (SHA256SUMS updated; patch tree unchanged).
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow-up fixes from my review of @krunkosaurus's stack (#26, #27, #28), kept out of his branches. Credit for the features goes to him.
engine/nvfp4/patches/0003-dialogue-speakers.patch: subject changed toserver: preserve dialogue speakers across long-form requeststo match the series' area prefixes. Only the patch header changes; SHA256SUMS updated.This branch is built on #28 with #27 merged in, so until the stack lands the diff also shows their commits. I'll update it on
mainafter #26-#28 merge; the follow-up itself is the last commit.Checks on this head:
sha256sum -c SHA256SUMSOK for all three patch dirs;python3 -m unittest discover -s recipe -p 'test_*.py'OK (skipped=15);bench/stream_check.py --self-testpassed;git diff --checkclean.