Repository navigation
[1/3] Preserve speech controls and CJK boundaries in long-form chunks - #26
Conversation
Linux --weights nvfp4 now applies the checksummed series in engine/nvfp4/patches/ (added in this PR), so list it with the other Apache-2.0 patch directories and drop "applies no patches".
|
Thank you for this, and for the careful write-up. I built the CUDA NVFP4 engine with this patch on Linux/CUDA 13 (GB10): 49/49 build steps, and |
|
I finished my own GPU checks for this stack on CUDA (full model and NVFP4, the merge base vs the #28 tip). For #26 everything I test passes:
One thing I saw is not from this PR: a long-form reply ends at the first segment that finishes on From my side this is ready. Whenever you're happy with it, please mark it ready for review and I'll merge the stack in order (#26, then #27, then #28). Thanks again! |
|
Hi @krunkosaurus, thanks again for this stack, and sorry for the wait. #26 and #27 pass my review and my CUDA GPU checks. #28 passes too, apart from the one full-model question I left there (tagged two-speaker line running to the frame cap in 3 of 5 seeds); a quick view from you on that is all I need, and I won't hold the merge on Metal checks you can't run. Could you mark #26, #27 and #28 ready for review? I'll merge them in order (#26, then #27, then #28) right away. Small fixes I'm taking on myself, with credit to you:
If I don't hear back within 24 hours, I'll take them as they are and merge. |
Description and motivation
Part 1 of 3 (merge order: this PR, #27 sampling, #28 dialogue): add CUDA NVFP4 patch
0001-protected-speech-chunks.patch, linked to native source PR #5. Closes #25.Long-form requests keep complete paired directions, bracket cues and special tokens; CJK boundaries work without ASCII spaces. Only an indivisible protected span may exceed the character target, while prompt/segment/frame limits and original-slice ownership remain enforced. Full-model and Metal NVFP4 long-form support is not added.
Enable a checksummed CUDA patch series without moving any engine/weight pin. Independent adversarial agent review found that the existing builder could apply an unlisted patch: a new regression reproduced that failure, and exact manifest coverage now rejects unlisted, missing, duplicate and non-patch entries before checkout.
The Sogni-AI/drama3-mlx chunker is the behavioral reference. Native code is implemented independently.
Testing
b1f4b9b4; resulting source tree equals reviewed native commit3babff30.Performance or quality claim
None.
Checklist