Repository navigation
Spec: a common table view and data file formats #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
olekslitus
wants to merge
14
commits into
main
Choose a base branch
from
common-view
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
a5db84b
Rename the project to lakekit
olekslitus 44a577d
Changelog: the rename from lakebed
olekslitus ba5b89c
Core: Store and Env instead of Host; an object_store adapter
olekslitus 3368fb3
Merge main (the squashed rename, #9) into store-env
olekslitus 6e863d8
Core: Clock and Random instead of Env
olekslitus aec2b9d
Core: Store, Clock, and Random come from loko
olekslitus 08595e1
Core: Resources, following loko's naming
olekslitus 04e6f60
Iceberg: rustfmt after the Resources rename
olekslitus 7468ed2
Core: draw identifiers and jitter from Random::rng
olekslitus eea4a77
Core: Resources is a #[loko::bundle], following loko
olekslitus c052853
Core: Resources implements loko's Has traits by hand, without loko-ma…
olekslitus 9883f68
Core: Services and MemoryServices again, as loko calls them services …
olekslitus ee74e3c
Core: Services is three borrowed services, not one value that is all …
olekslitus 5c86c39
Spec: a common table view (spec 5) and data file formats (spec 6)
olekslitus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,20 @@ | ||
| # lakekit-core | ||
|
|
||
| The I/O boundary of [lakekit](https://github.com/polythings/lakekit)'s table format crates. Format crates do no I/O of | ||
| their own: they call a `Host` that the application implements over its object store, clock, and randomness, so they | ||
| build for `wasm32-unknown-unknown` and native targets alike. | ||
| their own: they read and write through a `Store`, take the time from a `Clock`, and take random numbers from a | ||
| `Random`, all supplied by the application ([loko](https://github.com/polythings/loko)'s services, re-exported here), so they build for `wasm32-unknown-unknown` and native targets alike. | ||
|
|
||
| - `Host`: get, ranged get, exists, put, put-if-absent (the commit primitive), multipart upload, list, delete, the time, | ||
| random numbers, and waiting. Its futures aren't `Send`, so a host can wrap JavaScript promises. | ||
| - `MemoryHost`: a host in memory with a fixed clock and seeded randomness, for tests. | ||
| - `Error`: one error type, whose variant says what a caller can do (`NotFound`, `Conflict`, `CommitUnknown`, …). | ||
| - `Store`: get, ranged get, exists, put, put-if-absent (the commit primitive), multipart upload, list, delete. Its | ||
| futures aren't `Send`, so a store can wrap JavaScript promises. `loko-object-store` implements it over | ||
| `object_store`. | ||
| - `Clock`: the time and a timer. `TokioClock` (feature `tokio`, native only) uses the system clock and tokio's timer; | ||
| `TestClock` moves only when told. | ||
| - `Random`: random numbers. `OsRandom` (feature `getrandom`, native and WASI) uses the operating system's generator; | ||
| `SeededRandom` repeats a sequence from a seed. | ||
| - `Services`: a store, a clock, and a random source, each borrowed, for APIs that need all three (commits): | ||
| `Services::new(&store, &clock, &random)`. | ||
| - `uuid_v4`, `uuid_v7`: identifiers from a `Random` (and a `Clock`), with the `uuid` crate. | ||
| - `Error`: one error type, whose variant says what a caller can do (`NotFound`, `Conflict`, `CommitUnknown`, …); a | ||
| store's error converts into it. | ||
|
|
||
| Apache License 2.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Remove the stale
MemoryServicesreference from the changelog.Line 31 says "
MemoryHostisMemoryServices".lakekit-coredoes not exportMemoryServices.crates/lakekit-core/src/lib.rsexportsMemoryStore,TestClock, andSeededRandom.spec/0001-store-clock-random.mdalso records thatMemoryServicesis gone. A user who reads this entry will look for a type that does not exist.Name the real replacement instead.
📝 Proposed fix
As per coding guidelines: "a change in behaviour updates its spec (status, design, history), the tests, and
CHANGELOG.md(underUnreleased) in the same commit."📝 Committable suggestion
🤖 Prompt for AI Agents
Source: Coding guidelines