Skip to content

gh-156114: Fix crash in perf trampoline with unencodable code names - #156300

Merged
pablogsal merged 5 commits into
python:mainfrom
ashm-dev:gh-156114
Sep 18, 2026
Merged

gh-156114: Fix crash in perf trampoline with unencodable code names#156300
pablogsal merged 5 commits into
python:mainfrom
ashm-dev:gh-156114

Conversation

@ashm-dev

@ashm-dev ashm-dev commented Aug 23, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-app bedevere-app Bot mentioned this pull request Aug 23, 2026
Open
@ashm-dev

ashm-dev commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

@pablogsal could you review this? Fixes a crash in the perf trampoline with unencodable code names (gh-156114). Test included, CI green.

@pablogsal pablogsal added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Sep 18, 2026
@pablogsal
pablogsal merged commit 6dad8b8 into python:main Sep 18, 2026
66 checks passed
@miss-islington-app

miss-islington-app Bot commented Sep 18, 2026

Copy link
Copy Markdown

Thanks @ashm-dev for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@pablogsal

pablogsal commented Sep 18, 2026

Copy link
Copy Markdown
Member

Thanks a lot for the fix!

@miss-islington-app

miss-islington-app Bot commented Sep 18, 2026

Copy link
Copy Markdown

Sorry, @ashm-dev and @pablogsal, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6dad8b88cc39d8f9f41c22502a0b52304b326dd9 3.14

@bedevere-app

bedevere-app Bot commented Sep 18, 2026

Copy link
Copy Markdown

GH-157773 is a backport of this pull request to the 3.15 branch.

@miss-islington-app

miss-islington-app Bot commented Sep 18, 2026

Copy link
Copy Markdown

Sorry, @ashm-dev and @pablogsal, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6dad8b88cc39d8f9f41c22502a0b52304b326dd9 3.13

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Sep 18, 2026
This was referenced Sep 18, 2026
Merged
Merged
@bedevere-app

bedevere-app Bot commented Sep 18, 2026

Copy link
Copy Markdown

GH-157774 is a backport of this pull request to the 3.13 branch.

@bedevere-app

bedevere-app Bot commented Sep 18, 2026

Copy link
Copy Markdown

GH-157775 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Sep 18, 2026
pablogsal added a commit that referenced this pull request Sep 18, 2026
@pablogsal
[3.13] gh-156114: Fix crash in perf trampoline with unencodable code …
2aed763 
…names (GH-156300) (#157774)
pablogsal added a commit that referenced this pull request Sep 18, 2026
@pablogsal
[3.14] gh-156114: Fix crash in perf trampoline with unencodable code …
d3369c2 
…names (GH-156300) (#157775)
pablogsal pushed a commit that referenced this pull request Sep 18, 2026
@miss-islington
[3.15] gh-156114: Fix crash in perf trampoline with unencodable code …
3af62d9 
…names (GH-156300) (#157773)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Assignees

@pablogsal pablogsal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ashm-dev @pablogsal