[3.14] gh-156114: Fix crash in perf trampoline with unencodable code names (GH-156300) - #157775
Merged
Merged
Conversation
…ames (python#156300) (cherry picked from commit 6dad8b8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of GH-156300 to 3.14.
The older jitdump implementation formats the symbol name directly, so the conflict resolution clears encoding errors and substitutes empty strings there. The regression test and news entry are preserved.
All 15 tests in test_perf_profiler pass on a debug build. An initial run alongside the 3.13 suite failed because a perf map file was missing; the standalone rerun passes. Direct checks with unencodable qualified names and filenames also pass for both perf backends.
(cherry picked from commit 6dad8b8)
Co-authored-by: Shamil ashm.tech@proton.me
perf_map_write_entrywith lone surrogate in filename or qualname #156114