Repository navigation
fix(openstack): drop null overrides of resources cpu limits - #2530
Merged
Merged
Conversation
The upstream openstack-helm charts no longer set resources.cpu.limits, so our explicit `cpu: null` overrides had nothing to cancel. ArgoCD renders them as `cpu: "0"`, which shows up as a permanent diff on the affected Deployments, StatefulSets and CronJobs. Remove the overrides and the keys left empty by their removal, along with the comment explaining them. Memory limits and CPU requests are unchanged.
cardoe
enabled auto-merge
October 16, 2026 22:05
haseebsyed12
approved these changes
Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resources.cpu.limits, so ourcpu: nulloverrides had nothing left to cancel.cpu: "0", which showed up as a permanent diff (OutOfSync) on cinder, glance, horizon, ironic, keystone, neutron and nova.