Skip to content

fix(openstack): drop null overrides of resources cpu limits #2530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cardoe merged 1 commit into from
Oct 17, 2026
+0 −223
Merged

fix(openstack): drop null overrides of resources cpu limits #2530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions components/cinder/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,41 +103,16 @@ pod:
# usually set on per-deployment basis.
min_available: 0
resources:
# (doug.goldstein) No CPU limits, CFS throttling hurts more than it
# helps. Helm merges our values over the chart defaults, so the limits
# need an explicit null instead of just being left out.
enabled: true
api:
requests:
memory: "256Mi"
limits:
cpu: null
scheduler:
requests:
memory: "256Mi"
limits:
cpu: null
volume:
requests:
memory: "256Mi"
limits:
cpu: null
jobs:
db_sync:
limits:
cpu: null
ks_endpoints:
limits:
cpu: null
ks_service:
limits:
cpu: null
ks_user:
limits:
cpu: null
volume_usage_audit:
limits:
cpu: null

# (doug.goldstein) removed the 'identity' service dependency from all components,
# it is unused (the service) and other jobs wait on keystone working anyway.
Expand Down
26 changes: 0 additions & 26 deletions components/glance/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,38 +103,12 @@ pod:
api:
min_available: 1
resources:
# (doug.goldstein) No CPU limits, CFS throttling hurts more than it
# helps. Helm merges our values over the chart defaults, so the limits
# need an explicit null instead of just being left out.
enabled: true
api:
requests:
memory: "2560Mi"
limits:
memory: "6144Mi"
cpu: null
jobs:
bootstrap:
limits:
cpu: null
db_sync:
limits:
cpu: null
ks_endpoints:
limits:
cpu: null
ks_service:
limits:
cpu: null
ks_user:
limits:
cpu: null
metadefs_load:
limits:
cpu: null
storage_init:
limits:
cpu: null
probes:
api:
glance-api:
Expand Down
12 changes: 0 additions & 12 deletions components/horizon/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,22 +71,10 @@ pod:
# usually set on per-deployment basis.
min_available: 0
resources:
# (doug.goldstein) No CPU limits, CFS throttling hurts more than it
# helps. Helm merges our values over the chart defaults, so the limits
# need an explicit null instead of just being left out.
enabled: true
server:
requests:
memory: "512Mi"
limits:
cpu: null
jobs:
db_sync:
limits:
cpu: null
tests:
limits:
cpu: null

annotations:
# we need to modify the annotations on OpenStack Helm
Expand Down
21 changes: 0 additions & 21 deletions components/ironic/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,40 +352,19 @@ pod:
# allow for zero downtime ironic-api deployments by keeping an api node online
min_available: 1
resources:
# (doug.goldstein) No CPU limits, CFS throttling hurts more than it
# helps. Helm merges our values over the chart defaults, so the limits
# need an explicit null instead of just being left out.
enabled: true
api:
requests:
memory: "1024Mi"
cpu: "100m"
limits:
memory: "2048Mi"
cpu: null
conductor:
requests:
memory: "1024Mi"
cpu: "100m"
limits:
memory: "2048Mi"
cpu: null
novncproxy:
limits:
cpu: null
jobs:
db_sync:
limits:
cpu: null
ks_endpoints:
limits:
cpu: null
ks_service:
limits:
cpu: null
ks_user:
limits:
cpu: null
affinity:
anti:
type:
Expand Down
17 changes: 0 additions & 17 deletions components/keystone/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,108 +32,91 @@ dependencies:

pod:
resources:
# (doug.goldstein) No CPU limits, CFS throttling hurts more than it
# helps. Helm merges our values over the chart defaults, so the limits
# need an explicit null instead of just being left out.
enabled: true
api:
requests:
memory: "512Mi"
limits:
memory: "2048Mi"
cpu: null
jobs:
bootstrap:
requests:
memory: "64Mi"
cpu: "100m"
limits:
memory: "4096Mi"
cpu: null
domain_manage:
requests:
memory: "64Mi"
cpu: "100m"
limits:
memory: "4096Mi"
cpu: null
db_init:
requests:
memory: "64Mi"
cpu: "100m"
limits:
memory: "4096Mi"
cpu: null
db_sync:
requests:
memory: "64Mi"
cpu: "100m"
limits:
memory: "4096Mi"
cpu: null
db_drop:
requests:
memory: "64Mi"
cpu: "100m"
limits:
memory: "4096Mi"
cpu: null
rabbit_init:
requests:
memory: "64Mi"
cpu: "100m"
limits:
memory: "4096Mi"
cpu: null
tests:
requests:
memory: "64Mi"
cpu: "100m"
limits:
memory: "4096Mi"
cpu: null
fernet_setup:
requests:
memory: "64Mi"
cpu: "100m"
limits:
memory: "4096Mi"
cpu: null
fernet_rotate:
requests:
memory: "64Mi"
cpu: "100m"
limits:
memory: "4096Mi"
cpu: null
credential_setup:
requests:
memory: "64Mi"
cpu: "100m"
limits:
memory: "4096Mi"
cpu: null
credential_rotate:
requests:
memory: "64Mi"
cpu: "100m"
limits:
memory: "4096Mi"
cpu: null
credential_cleanup:
requests:
memory: "64Mi"
cpu: "100m"
limits:
memory: "4096Mi"
cpu: null
image_repo_sync:
requests:
memory: "64Mi"
cpu: "100m"
limits:
memory: "4096Mi"
cpu: null
probes:
api:
api:
Expand Down
29 changes: 0 additions & 29 deletions components/neutron/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,9 +184,6 @@ pod:
server:
min_available: 2
resources:
# (doug.goldstein) No CPU limits, CFS throttling hurts more than it
# helps. Helm merges our values over the chart defaults, so the limits
# need an explicit null instead of just being left out.
enabled: true
server:
# give neutron-server more CPU headroom
Expand All @@ -195,32 +192,6 @@ pod:
cpu: "500m"
limits:
memory: "8192Mi"
cpu: null
rpc_server:
limits:
cpu: null
periodic_worker:
limits:
cpu: null
ovn_maintenance_worker:
limits:
cpu: null
ironic_agent:
limits:
cpu: null
jobs:
db_sync:
limits:
cpu: null
ks_endpoints:
limits:
cpu: null
ks_service:
limits:
cpu: null
ks_user:
limits:
cpu: null
# loosen the neutron-server liveness probe so a slow response during a burst
# of load doesn't trigger a destructive pod restart. A liveness probe should
# detect a dead process, not a busy one. Readiness failing under load is fine
Expand Down
33 changes: 0 additions & 33 deletions components/nova/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,9 +314,6 @@ pod:
timeoutSeconds: 10
failureThreshold: 3
resources:
# (doug.goldstein) No CPU limits, CFS throttling hurts more than it
# helps. Helm merges our values over the chart defaults, so the limits
# need an explicit null instead of just being left out.
enabled: true
api:
# JIRA:PUC-2007 - raise osapi resources. Heavy all_tenants queries with 8
Expand All @@ -325,43 +322,13 @@ pod:
cpu: "500m"
memory: "512Mi"
limits:
cpu: null
memory: "2Gi"
api_metadata:
limits:
cpu: null
conductor:
requests:
memory: "256Mi"
limits:
cpu: null
scheduler:
limits:
cpu: null
compute_ironic:
requests:
memory: "256Mi"
limits:
cpu: null
jobs:
bootstrap:
limits:
cpu: null
cell_setup:
limits:
cpu: null
db_sync:
limits:
cpu: null
ks_endpoints:
limits:
cpu: null
ks_service:
limits:
cpu: null
ks_user:
limits:
cpu: null

manifests:
job_db_init: false
Expand Down
33 changes: 0 additions & 33 deletions components/octavia/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,43 +164,10 @@ pod:
- secret:
name: octavia-ks-etc
resources:
# (doug.goldstein) No CPU limits, CFS throttling hurts more than it
# helps. Helm merges our values over the chart defaults, so the limits
# need an explicit null instead of just being left out.
enabled: true
api:
requests:
memory: "512Mi"
limits:
cpu: null
driver_agent:
limits:
cpu: null
worker:
limits:
cpu: null
housekeeping:
limits:
cpu: null
health_manager:
limits:
cpu: null
jobs:
bootstrap:
limits:
cpu: null
db_sync:
limits:
cpu: null
ks_endpoints:
limits:
cpu: null
ks_service:
limits:
cpu: null
ks_user:
limits:
cpu: null

manifests:
job_db_init: false
Expand Down
Loading
Loading