Add ReactNativeVersion.h to react/utils (#58403) - #58403
Open
j-piasecki wants to merge 7 commits into
Open
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D119163947. |
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 9, 2026
Summary: Pull Request resolved: react#58403 Changelog: [General][Added] - Added `ReactNativeVersion.h` to public `react/utils` module. Existing one inside private `cxxreact/bridge` module is now deprecated and still accessible when not opted in to `RN_STRICT_API`. Differential Revision: D119163947
meta-codesync
Bot
changed the title
j-piasecki
force-pushed
the
export-D119163947
branch
from
September 9, 2026 09:22
ede953c to
74f4cd6
Compare
Summary: Classifies `react/utils:utils` as a public target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/UmbrellaGuard.h>` to the module's 22 exported headers and introduces the module umbrella `React/Utils.h`, wiring the guard dependency into BUCK, CMake and CocoaPods and the umbrella into BUCK, CocoaPods, the iOS prebuild header config and the Android prefab export. Consumers that opt into `RN_STRICT_API` now get an error if they include the module's headers directly, and should include `<React/Utils.h>` instead; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Differential Revision: D117858212
Summary: Classifies `cxxreact:jsbigstring` as a public target under the C++ stable API three-tier visibility model. Adds `#include <react/cxxstableapi/UmbrellaGuard.h>` to the target's 2 exported C++ headers and introduces the module umbrella `React/JSBigString.h`, wiring the guard dependency into BUCK, CMake and CocoaPods and the umbrella into BUCK, CMake, CocoaPods, the iOS prebuild header config and the Android prefab export. Consumers that opt into `RN_STRICT_API` now get an error if they include the target's headers directly, and should include `<React/JSBigString.h>` instead; without that flag the guards are inert, so no existing build changes behaviour. Under `USE_FRAMEWORKS` the pod now maps its headers relative to `ReactCommon`, so they install under `cxxreact/` inside the built framework rather than at its root. Pods that pick up the framework's `Headers` directory through `install_modules_dependencies` are unaffected. `React-RCTFabric`, `ReactCommon` and `React-NativeModulesApple` pin their own search paths instead and are updated here; pods outside the repository that do the same have to make the equivalent change. Changelog: [iOS][Breaking] - Install `React-cxxreact` headers under `cxxreact/` inside its framework when `USE_FRAMEWORKS` is enabled. Pods that include `<cxxreact/...>` without calling `install_modules_dependencies` must add `React_cxxreact.framework/Headers` to `HEADER_SEARCH_PATHS`. Differential Revision: D119144023
Summary: Classifies `cxxreact:messagequeuethread` as a "for frameworks" target under the three-tier C++ stable API visibility model. Consumers that opt into `RN_STRICT_API` now get a warning if they include its headers directly, which they can acknowledge with `RN_ALLOW_FRAMEWORKS`; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Differential Revision: D119163883
Summary: Classifies `cxxreact:tracesection` as a "for frameworks" target under the three-tier C++ stable API visibility model. Consumers that opt into `RN_STRICT_API` now get a warning if they include its headers directly, which they can acknowledge with `RN_ALLOW_FRAMEWORKS`; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Differential Revision: D119163904
Summary: Classifies `cxxreact:module` as a private target under the three-tier C++ stable API visibility model. Consumers that opt into `RN_STRICT_API` now get an error if they include its headers directly; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Differential Revision: D119163922
Summary: Classifies `cxxreact:bridge` as a private target under the three-tier C++ stable API visibility model. Consumers that opt into `RN_STRICT_API` now get an error if they include its headers directly; without that flag the guards are inert, so no existing build changes behaviour. `ReactNativeVersion.h` is a generated file, so its guard also goes into `scripts/releases/templates/ReactNativeVersion.h-template.js`; without that the next version stamp would rewrite the header and silently drop the guard from every release and nightly artifact. Changelog: [Internal] Differential Revision: D119163927
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 9, 2026
Summary: Pull Request resolved: react#58403 Changelog: [General][Added] - Added `ReactNativeVersion.h` to public `react/utils` module. Existing one inside private `cxxreact/bridge` module is now deprecated and still accessible when not opted in to `RN_STRICT_API`. Differential Revision: D119163947
j-piasecki
force-pushed
the
export-D119163947
branch
from
September 9, 2026 10:08
74f4cd6 to
eedc0df
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 9, 2026
Summary: Pull Request resolved: react#58403 Changelog: [General][Added] - Added `ReactNativeVersion.h` to public `react/utils` module. Existing one inside private `cxxreact/bridge` module is now deprecated and still accessible when not opted in to `RN_STRICT_API`. Differential Revision: D119163947
j-piasecki
force-pushed
the
export-D119163947
branch
from
September 9, 2026 10:57
eedc0df to
64b5373
Compare
Summary: Pull Request resolved: react#58403 Changelog: [General][Added] - Added `ReactNativeVersion.h` to public `react/utils` module. Existing one inside private `cxxreact/bridge` module is now deprecated and still accessible when not opted in to `RN_STRICT_API`. Reviewed By: javache Differential Revision: D119163947
j-piasecki
force-pushed
the
export-D119163947
branch
from
September 9, 2026 13:57
64b5373 to
dc1089a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [General][Added] - Added
ReactNativeVersion.hto publicreact/utilsmodule.Existing one inside private
cxxreact/bridgemodule is now deprecated and still accessible when not opted in toRN_STRICT_API.Reviewed By: javache
Differential Revision: D119163947