Skip to content

chore(protocol): remove the unused CLI telemetry contract - #148

Merged
harlan-zw merged 1 commit into
mainfrom
chore/remove-cli-telemetry-contract
Sep 16, 2026
Merged

harlan-zw merged 1 commit into
mainfrom
chore/remove-cli-telemetry-contract

Conversation

@harlan-zw

Copy link
Copy Markdown
Collaborator

❓ Type of change

  • 🧹 Chore
  • ⚠️ Breaking change

📚 Description

Privacy is becoming a skilld.dev tenet. skilld-protocol still shipped a CliEventInputSchema with a userId field, but no CLI code ever sent those events. I deleted it with the telemetry constants and fixtures, and added a README Privacy section listing the only network requests the CLI makes.

The Rust CLI sweep found no telemetry, machine ids, or hostname reads. The daily upgrade check already skips CI, Agents, and SKILLD_NO_UPGRADE=1.

⚠️ Breaking Changes

CliEventInputSchema, TELEMETRY_EVENTS, TELEMETRY_SURFACES, and AUTH_FLOWS leave the protocol package.

📝 Migration

skilld.dev imports CliEventInputSchema for /api/events/cli. Merge the site PR that deletes that route before the site takes the next protocol version.

🤖 AI disclosure: Harlan Agent Kit modified this description. My AI open-source policy.

The CLI never sent telemetry events, yet the schema carried a user id and
invited a future caller. Privacy is a skilld.dev tenet, so the README now
lists every network request the CLI makes.
@harlan-github-agent harlan-github-agent Bot added harlan-agent-running An Agent holds a Task on this issue or pull request right now. harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. labels Sep 16, 2026
@harlan-github-agent

harlan-github-agent Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

🤖 MERGED

Harlan Agent Kit posted this automated review. It is not Harlan's personal review or approval. AI open source policy. Last updated: 2026-09-16 16:09 UTC.

GitHub merged this pull request.

No material findings were recorded.

1bfefd6e-e80a-418c-b2af-e15649c1adae

@harlan-github-agent harlan-github-agent Bot added harlan-agent-pending The automated Review is waiting on a gate for this head commit. harlan-agent-ready The automated Review passed every gate on this head commit. and removed harlan-agent-running An Agent holds a Task on this issue or pull request right now. harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. harlan-agent-pending The automated Review is waiting on a gate for this head commit. labels Sep 16, 2026
@harlan-zw
harlan-zw added this pull request to stack #150 September 16, 2026 15:00
@harlan-zw
harlan-zw merged commit 880b5ec into main Sep 16, 2026
2 checks passed
@harlan-github-agent harlan-github-agent Bot removed the harlan-agent-ready The automated Review passed every gate on this head commit. label Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant