Skip to content

Expose DiffView without importing the terminal workspace - #443

Closed
drewstone wants to merge 3 commits into
mainfrom
fix/isolated-diff-entry-10478
Closed

drewstone wants to merge 3 commits into
mainfrom
fix/isolated-diff-entry-10478

Conversation

@drewstone

@drewstone drewstone commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

An artifact-only consumer importing DiffView through the Workbench barrel also loads terminal modules. Agent Record's actual standalone build failed on three optional xterm named exports even though it does not use a terminal.

Expose the existing component and its type through @tangle-network/sandbox-ui/workbench/diff, with matching package export, build entry and source re-export. The existing Workbench export stays available. There is one DiffView implementation and no component, style or peer-range change. README documents the focused import.

The existing real packed-consumer proof now builds EmbeddedAppView and DiffView together without xterm. It reads dependency versions from the tarball's manifest, honors peer compatibility, and refuses nested terminal packages rather than inspecting only the top-level directory. No unit or mock test was added.

Scope/risk: an additive public subpath and its packed integration check. Patch version 0.136.2; no terminal dependencies added. Corrections ship forward.

Merge preconditions: exact-head guarded Linux qualification, packed focused-consumer proof and independent source review; received findings resolved. Repository-required Linux signoff and normal release artifact checks must be retained. This remains draft until those checks are evidenced. No Mac install/build/test was run.

After normal merge, the maintained release workflow packs once, tests that tarball and verifies the same bytes at npm and GitHub Packages. Agent Record PR146 then adopts the published version and focused imports; its owner retains final rendered and served-product proof. Publication and consumer adoption are not yet claimed.

Independent source review approved the complete frozen six-file head 8d55a61d2b6a1000b8b83c970bdd7802b45920a6 with no blocking finding. The sole normal Linux qualifier request-_8x467me ended at 2026-10-24T10:04:23Z with exit75, two maintained admission attempts and zero placements. Frozen install, signoff and packed-consumer execution remain UNRUN. Existing operator owns the next actual changed-capacity callback; the cooldown timestamp alone does not authorize rearming. No qualification job remains live. Publication and application adoption remain unproved.

The current frozen head is 317332765579e1d186cb41c757d392c5298da11c. The target consumer now uses UI11.42.0 and Brand1.26.2; Sandbox aligns its hard dependency and peer floors to that cohort, removes the duplicate UI dev declaration, and uses the normally regenerated lock. No component or style implementation changed. The existing real packed consumer also requires one physical UI directory after normal npm peer resolution. The complete source and the cohort/assertion successor are independently source approved; Linux execution remains UNRUN.

Current operator admission order places SDK443 after the named priority admissions. No SDK qualifier is live. One exact successor qualification will run on the actual named callback; neither the old cooldown nor free-disk headroom alone is an admission grant. Agent Record adoption will target its current integrated one-pane source after publication, preserving its existing live baseline.

@drewstone

Copy link
Copy Markdown
Contributor Author

Owner: op-company:sandbox-ui (repo lane; live). The writer is the #10478 root/retention session on the Mac, which has no fleet route; consumer is agent-record PR146.
Blocker: draft and CONFLICTING with main. #444 (421586a) already landed the ui 11.42.0 alignment and a DiffView fix, so the cohort part of this branch overlaps main. Linux qualification, packed focused-consumer proof and signoff are UNRUN (the only qualifier ended exit 75 with zero placements).
Next action: sandbox-ui rebases this onto main, keeping only the additive workbench/diff subpath and its packed-consumer check, gets the exact-head Linux gate, then marks it ready and merges. Or it closes this with proof that main already exposes the focused import.

@drewstone

Copy link
Copy Markdown
Contributor Author

Superseded by #452 (merged as a2c03e2, ships in 0.138.0): its focused ./workbench/diff entry and packed-consumer check are folded in there.

@drewstone drewstone closed this Oct 26, 2026

This branch was successfully deployed

1 active deployment
preview — 31733276 Deployed Oct 24, 2026 by github-actions[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant