Repository navigation
Conversation
What was broken Registrants and copilots missed new challenge-topic emails and could not manage a challenge-wide watch preference. Root cause Notifications resolved only explicit topic/ancestor watches. Top-level challenge-topic creation also skipped the post-commit notification path. What was changed Resolve default challenge-wide watches from Submitter and Copilot resource assignments. Persist explicit watch/unwatch choices in ChallengeForumWatch, expose authenticated member preference endpoints, and include forum watchers in new-topic/post notifications using the existing visibility and ban policy. Publish top-level challenge starter notifications after commit. Add the migration, regenerate the exported Prisma client, and document deployment. Any added/updated tests Add resource/default-watch and preference authorization tests, new-topic recipient and post-commit tests, and HTTP opt-out/re-watch coverage. Lint and build pass. The normal suite plus moderation database checks passes 181 tests. Running every PostgreSQL suite passes 188 tests and reproduces one pre-existing public-import provenance failure on unchanged origin/develop. All five migrations and empty-forum preference persistence pass locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Registrants and copilots missed emails when a new challenge forum topic was created. Members also had no challenge-wide watch preference to control those notifications.
Root cause
Recipients came only from explicit topic/ancestor watches, and top-level challenge-topic creation skipped notification publishing entirely.
What was changed
ChallengeForumWatch; add authenticated current-member GET/PUT/DELETE/v6/forums/challenges/:challengeId/watchendpoints.Deploy migration
20261016000000_challenge_forum_watch, then this API, before platform-ui PR #2499.Any added/updated tests
Added resource-role/default-watch, preference persistence/authorization, recipient filtering, post-commit publication, and HTTP opt-out/re-watch regressions.
Validation (after
nvm use):pnpm lintandpnpm build: passed.pnpm test --runInBandwith local moderation database checks: 181 passed; the separate public-forums database suite remains opt-in.category-topic:99001failure reproduces on unchangedorigin/develop.pnpm exec prisma migrate deploy: all five migrations passed on disposable PostgreSQL.No dependencies were upgraded. Existing unrelated worktrees were left untouched.