Repository navigation
Conversation
What was broken Members could watch individual topics but could not change notification preferences for the entire challenge forum, including future topics. Root cause The forum overview exposed only topic-specific watch actions and had no challenge-wide preference API integration. What was changed Add Watch forum / Unwatch forum to the challenge overview, including empty forums. Load the current member's effective preference and persist choices through the companion Forums API endpoints. Disable unavailable/pending controls, preserve state after failed saves, and show a retry for failed reads. Document the API and migration deployment dependency. Any added/updated tests Add service routing and component regressions for opt-out/re-watch, empty forums, failed saves, and loading/read errors. The 49 forum tests and lint pass. The full UI suite reports 387 passing and 22 failing suites; 21 failures reproduce on unchanged origin/dev, and the remaining suite passes in isolation on both branches. The production build passes with a 12 GB Node heap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Members had no Watch/Unwatch control for the entire challenge forum, so they could not manage notifications for future topics from the overview.
Root cause
The overview supported only individual topic watches and did not load or save a challenge-wide preference.
What was changed
Requires forums-api-v6 PR #19. Deploy its
ChallengeForumWatchmigration and API before this UI change. The API defaults registrants and copilots to watching; explicit topic watches remain independent.Any added/updated tests
Added four regressions across
ChallengeForum.spec.tsxandforum.service.spec.ts: endpoint routing, empty-forum opt-out/re-watch, failed saves, and loading/read errors.Validation (after
nvm use):yarn lint: passed.yarn test:no-watch --runInBand --runTestsByPath src/apps/opportunities/src/components/ChallengeForum.spec.tsx src/apps/opportunities/src/services/forum.service.spec.ts: 49 passed.yarn test:no-watch --runInBand: 387 suites / 2,730 tests passed; 22 suites failed. Re-running the failures on unchangedorigin/devreproduces 21 failing suites and all 19 failed assertions. The remaining salesforce-sync suite passes in isolation on both branches. Existing failures include stale expectations, missing test mocks, and unresolved test aliases in unrelated apps.NODE_OPTIONS=--max-old-space-size=12288 yarn run build: passed. The initial build exhausted Node's default heap; no build configuration or dependency changes were needed.No dependencies were upgraded. Existing unrelated worktrees were left untouched.