Repository navigation
fix(mac): stabilize selected-text cleanup and coverage checks - #471
Merged
Merged
Conversation
scttbnsn
requested review from
ALARGECOMPANY,
biggest-littlest and
dstahl11
as code owners
October 25, 2026 17:20
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
 |
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selected-text cleanup now captures the selection off the main thread, resolves website-specific tone within a bounded read, and rejects stale or cancelled preparation before showing a preview. Stabilize Settings keyboard/render tests with serialized AppKit setup, and keep safe offscreen keyboard/window checks in CI while retaining local focus-taking tests.
Enforce the existing 80% overall Swift line-coverage floor using exact covered/total counts, including rejection of values below the floor that display as 80.00%. Source exclusions and protection rules are unchanged.
Validation: the native source, tests, scripts and package files are identical to the locally verified candidate with 2,696 CI-equivalent tests, 38,143/47,666 covered lines (80.02%), five complete Settings runs and bounded selection regressions. Reconstruction onto current dev preserves the exact diff and both website fixes. Fresh strict formatting and both coverage-floor regression tests pass. The fresh pre-push gate passed strict formatting and the warnings-as-errors build. Its successful build still emitted existing Sendable-capture diagnostics in unchanged GlassPillPolicy.swift; enforcement of those diagnostics is a separate follow-up. Physical language and hardware acceptance remain separate.