Repository navigation
Add QR canvas captions and call-to-action frames - #301
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 7 seconds. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PrzemyslawKlys
force-pushed
the
feature/qr-art-v2-wave2
branch
from
October 24, 2026 23:10
9de89a6 to
cb5e0d5
Compare
PrzemyslawKlys
force-pushed
the
feature/qr-art-v2-wave3
branch
from
October 24, 2026 23:10
595a929 to
b229d87
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #301 +/- ##
==========================================
+ Coverage 72.68% 72.75% +0.07%
==========================================
Files 899 901 +2
Lines 82441 82548 +107
Branches 24005 24052 +47
==========================================
+ Hits 59925 60061 +136
+ Misses 13592 13541 -51
- Partials 8924 8946 +22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
PrzemyslawKlys
force-pushed
the
feature/qr-art-v2-wave2
branch
from
October 24, 2026 23:59
cb5e0d5 to
24ea8d7
Compare
PrzemyslawKlys
force-pushed
the
feature/qr-art-v2-wave3
branch
from
October 24, 2026 23:59
b229d87 to
7f674e3
Compare
PrzemyslawKlys
force-pushed
the
feature/qr-art-v2-wave2
branch
from
October 25, 2026 00:12
24ea8d7 to
c8fbbb5
Compare
PrzemyslawKlys
force-pushed
the
feature/qr-art-v2-wave3
branch
from
October 25, 2026 00:12
7f674e3 to
45f07cc
Compare
PrzemyslawKlys
force-pushed
the
feature/qr-art-v2-wave2
branch
from
October 25, 2026 01:06
c8fbbb5 to
f99dc95
Compare
PrzemyslawKlys
force-pushed
the
feature/qr-art-v2-wave3
branch
from
October 25, 2026 01:06
45f07cc to
60fa3e0
Compare
PrzemyslawKlys
force-pushed
the
feature/qr-art-v2-wave2
branch
from
October 25, 2026 02:30
f99dc95 to
0e43fd0
Compare
PrzemyslawKlys
force-pushed
the
feature/qr-art-v2-wave3
branch
from
October 25, 2026 03:32
60fa3e0 to
51b415a
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QR canvases now support captions above or below the complete quiet zone, with a portable font, regular or bold weight, colour and bounded single-line fitting. Six templates provide a scan-me pill, speech bubble, ticket stub, phone outline, card header and corner viewfinder. The existing thin frame stays visible outside the QR panel.
PhoneOutline reserves space for the notch and home indicator, plus a gap, so neither bar crosses the caption. Geometry checks cover every frame style at both caption positions, minimum and default padding, and normal and supersampled output.
The renderer reuses the managed font and outline rasterizer, preserves QR and quiet-zone pixels, and exports the same coverage in PNG and SVG. Captions smaller than eight final output pixels are rejected, including with background supersampling. Captions and frames participate in native rendered-image validation; a failed check throws.
Validation: all 81 focused caption tests pass on .NET 8, .NET 10 and .NET Framework 4.7.2. All 48 updated gallery specimens pass native validation and strict independent full-size and half-size reads. The earlier focused Linux caption and no-deadline scanner checks pass on .NET 8 and .NET 10. The rebase onto merged #300 preserves the validated source tree; current CI runs against that base.
Legacy native decoding has narrower support and cooperative scan deadlines. The geometry/export contract checks that accepted PNGs preserve the expected pixels and rejected appearances throw the native-validation error. Guardrails stay enabled. Timed caption checks use the existing nonparallel collection.
Builds on merged #299 and #300.