Repository navigation
Conversation
Replaying captured changes in reverse can re-insert a child row before its deleted parent; PRAGMA defer_foreign_keys checks constraints once at commit. Fixes test_delete_with_cascade_and_later_edit_are_seen (the FK failure that kept CI red).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the red Backend tests on main and every branch based on it: tests/test_change_capture.py::test_delete_with_cascade_and_later_edit_are_seen fails with sqlite3.IntegrityError FOREIGN KEY constraint failed. Split out of PR 165. Once merged, 162 and 165 should go green after a rebase.