Repository navigation
[3/3] Preserve dialogue speaker roles across all pinned Drama engines - #28
krunkosaurus wants to merge 5 commits into
Conversation
|
Thanks for carrying the speaker through long-form continuations so carefully. The tests around hard cuts and redraws are great. Two small things: CUDA patch 0003's subject starts with "Drama speech:", while the series uses |
|
My CUDA checks for #28 mostly pass: tags 1 and 15 are accepted, untagged requests are unchanged, and when a long-form reply reaches its second segment the continuation carries the right speaker (5 of 8 seeds reached it, all carried correctly). One thing I'd like your view on before I merge: on the full model ( |
Description and motivation
Part 3 of 3. Merge #26, then #27, then this PR. The incremental change is cb20bda...0b2e000.
Accept canonical
<|speaker:0|>through<|speaker:15|>tags in speech input and reference transcripts. Untagged input remains speaker 0; malformed/structural tokens still fail validation. Full-model/Metal catalogs and the Python writer retain their four-reference cap; legacy CUDA retains its existing body/file/prompt limits.Append full-model patch 0015, Metal NVFP4 patch 0006 and CUDA NVFP4 patch 0003, and update the Python catalog writer, examples, indexes and checksums. Source companions: modern #1278 and legacy #7. Legacy continuation carries the active speaker across chunks, paragraph cuts, history eviction and redraws. Patch 0001 is required to keep speaker markers intact at hard cuts; the combined regression also exercises explicit sampling and an exact seed above 2^53.
The public Sogni-AI/drama3-mlx prompt tests are the behavioral reference. This independently extends TensorFold's native prompt builder; no Fish-derived Python implementation is copied.
Testing
c8463349(full),a6de32a3(Metal), and9e782dc9(CUDA).scripts/build-engine.shruns on those complete series passed: 66/66 full-model steps and 73/73 Metal NVFP4 steps, including the native server and selected voice tools (macOS arm64, Zig 0.17.0).60eb5d21: 784/787 CPU/host tests passed, three skipped, 9/9 build steps. Independent agent review verified the merge retains both feature implementations and test modules.test-pull-hostaborts with ISCONN, andtf-flashnext-runfails on SharedEvent/Event. Both reproduce on the untouched base.During final CPU replays, two unchanged recall tests failed while the volume had about 3.3 GiB free, below their existing 4 GiB admission floor. Removing only task-created compiler caches restored 5.043 GiB; the identical commands passed with no source, environment or admission-guard change. Original failure receipts were retained.
Performance or quality claim
None. Speaker labels do not guarantee distinct or faithfully cloned voices.
Checklist