Repository navigation
fix(workbench): DiffView renders on @pierre/diffs 1.6 - #444
Conversation
tangletools
left a comment
tangletools
left a comment
There was a problem hiding this comment.
✅ Auto-approved PR — 7bf2490c
Blanket team auto-approval is intentional. This is not a code review.
No automated review runs on this PR. This approval rests on the rule above alone.
tangletools · auto-approval · reason: blanket_auto_approve · 2026-10-24T21:25:58Z
|
Gate on beelink (head of this PR) failed typecheck with 13 errors, all in src/primitives/index.ts: HoverCard*, Breadcrumb* are not exported by @tangle-network/ui/primitives. origin/main f30ed4b fails the same typecheck with the same 13 errors (gate log on GTR scratchpad gate-sui-main.log), so main is red independent of this change; the lockfile resolves @tangle-network/ui 11.40.2 and 11.40.1 side by side. Not merging over a red gate. This one-line fix waits for main's typecheck to be green; agent-record pins @pierre/diffs 1.5.2 meanwhile (drewstone/agent-record#158). |
|
Folding this into the sandbox-ui lane's single patch release (fix/ui-11-42, with the WorkspaceFilesPane focus-on-load fix and the ui 11.42 main repair), so one SDK patch carries all three consumer fixes. I will close this PR as folded once that PR merges; agent-record then adopts the published version and drops its @pierre/diffs 1.5.2 override. |
tangletools
left a comment
tangletools
left a comment
There was a problem hiding this comment.
✅ Auto-approved PR — 17cbf62c
Blanket team auto-approval is intentional. This is not a code review.
No automated review runs on this PR. This approval rests on the rule above alone.
tangletools · auto-approval · reason: blanket_auto_approve · 2026-10-25T00:17:56Z
….6, files pane keeps scroll on load (#447) fix: build on @tangle-network/ui 11.42.0, DiffView on @pierre/diffs 1.6, files pane keeps scroll on load **Problem.** Three production consumer bugs in one shared dependency, folded into one patch release (root consolidation 2026-10-25 00:14Z; agent-record closes #444 as folded): main's Storybook and package builds fail with MISSING_EXPORT: `src/primitives/index.ts` re-exports `HoverCard*`, `Breadcrumb` and other primitives that `@tangle-network/ui` 11.40.x does not export (run 40143007375). `DiffView` draws nothing on `@pierre/diffs` 1.6 (third `FileDiff` argument became `requestOwnerRender`; "e is not a function", 0 px pane). From #444 (7bf2490), authored by agent-record. `WorkspaceFilesPane` Run ID: run_9600d4f3ec2a3cd6b350309083c935e5
DiffView draws nothing with @pierre/diffs 1.6.x, which
^1.5.1resolves to.diff-view.tsxbuilds the diff asnew FileDiff(options, undefined, false). The third argument wasisContainerManagedin 1.5. In 1.6.0 (published 2026-10-20) it isrequestOwnerRender, andFile/FileDiff.requestRender()calls it whenever it is not null. Sofalse()throws "TypeError: e is not a function", thediffs-containerstays 0 px tall, and the pane shows only its toolbar. The Discovery run page has shown an empty diff for every file since agent-record 0.59.0; both production and a preview showed the error andheight: 0in the browser.The fix leaves the argument out. That renders on 1.5 (
isContainerManageddefaults to false) and on 1.6 (no owner render), so^1.5.1holds. Patch changeset included.Proof: the same code path rendered once
@pierre/diffswas 1.5.2 (agent-record's interim pin, drewstone/agent-record#158): shadow DOM 130,530 chars, 2,773 px tall, the memwire.rs diff drawn. The Beelink gate runs typecheck, build and the DiffView tests (diff-view.test.tsx, diff-view.readability.test.tsx).Run ID: run_dc4269900ecbb231f70274ad2ff71824