Skip to content

Enforce strict ty rules across the workspace with a single uv check - #956

Draft
Sun Haoran (haoranpb) wants to merge 1 commit into
ty/strict-direct-dependenciesfrom
ty/strict-workspace
Draft

Sun Haoran (haoranpb) wants to merge 1 commit into
ty/strict-direct-dependenciesfrom
ty/strict-workspace

Conversation

@haoranpb

@haoranpb Sun Haoran (haoranpb) commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

What

Workspace config only, no Python changes:

  • Replace the two ty hooks with one uv check --all-packages --locked --no-sync. With --all-packages uv uses the root dev group's locked ty, fixing the floating-version drift that broke pre-commit.
  • Move [tool.ty.rules] all = "error" from bcbench-core to the root so it applies to every workspace member; TY_UV still checks direct dependencies per member.
  • Update the bcbench-core README dev command.

Note: a future ty bump (0.0.85) will surface truthiness-test-of-none-union in the app; that should be fixed in the bump PR.

Part of the stack that makes ty strict (all = "error") across the whole uv workspace. Each PR fixes one rule in Python code only; the config change lands in #956.

@github-code-quality

github-code-quality Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: Python

Python / code-coverage/pytest

The overall line coverage in commit 02c9415 in the ty/strict-workspace branch remains at 86%, unchanged from commit d19989f in the ty/strict-direct-dep... branch.

Show a line coverage summary of the most impacted files.
File ty/strict-direct-dep... d19989f ty/strict-workspace 02c9415 +/-
src/bcbench/eva...stgeneration.py 43% 42% -1%
src/bcbench/col...t_codereview.py 89% 88% -1%
src/bcbench/types.py 91% 92% +1%
src/bcbench/com...nds/evaluate.py 76% 77% +1%
src/bcbench/eva...te/dataquery.py 67% 69% +2%
src/bcbench/evaluate/nl2al.py 79% 81% +2%
src/bcbench/age...t/shared/mcp.py 92% 95% +3%
src/bcbench/eva...st_implement.py 65% 69% +4%
src/bcbench/evaluate/bugfix.py 47% 52% +5%
src/bcbench/eva...quest_triage.py 55% 62% +7%

Updated October 07, 2026 13:48 UTC

Run one 'uv check --all-packages' hook, which uses the ty locked by the root dev group, and move the 'all = error' baseline from bcbench-core to the root so it applies to every workspace member.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 70c54f79-d7a0-4cde-baf2-e53dfff3deb4

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant